chore: fix ConsoleMetricExporter

open-telemetry · Apr 9, 2020 · 09c7cc3 · 09c7cc3
1 parent 57a2184
commit 09c7cc3
Show file tree

Hide file tree

Showing 2 changed files with 23 additions and 23 deletions.
diff --git a/packages/opentelemetry-metrics/src/export/ConsoleMetricExporter.ts b/packages/opentelemetry-metrics/src/export/ConsoleMetricExporter.ts
@@ -14,8 +14,7 @@
  * limitations under the License.
  */
 
-import { MetricExporter, MetricRecord, MetricKind, Sum } from './types';
-import { Distribution } from './aggregators';
+import { MetricExporter, MetricRecord, Distribution, Histogram } from './types';
 import { ExportResult } from '@opentelemetry/base';
 
 /**
@@ -30,25 +29,26 @@ export class ConsoleMetricExporter implements MetricExporter {
     for (const metric of metrics) {
       console.log(metric.descriptor);
       console.log(metric.labels);
-      switch (metric.descriptor.metricKind) {
-        case MetricKind.COUNTER:
-          const sum = metric.aggregator.toPoint().value as Sum;
-          console.log('value: ' + sum);
-          break;
-        default:
-          const distribution = metric.aggregator.toPoint()
-            .value as Distribution;
-          console.log(
-            'min: ' +
-              distribution.min +
-              ', max: ' +
-              distribution.max +
-              ', count: ' +
-              distribution.count +
-              ', sum: ' +
-              distribution.sum
-          );
-          break;
+      const point = metric.aggregator.toPoint();
+      if (typeof point.value === 'number') {
+        console.log('value: ' + point.value);
+      } else if (typeof (point.value as Histogram).buckets === 'object') {
+        const histogram = point.value as Histogram;
+        console.log(
+          `count: ${histogram.count}, sum: ${histogram.sum}, buckets: ${histogram.buckets}`
+        );
+      } else {
+        const distribution = point.value as Distribution;
+        console.log(
+          'min: ' +
+            distribution.min +
+            ', max: ' +
+            distribution.max +
+            ', count: ' +
+            distribution.count +
+            ', sum: ' +
+            distribution.sum
+        );
       }
     }
     return resultCallback(ExportResult.SUCCESS);

diff --git a/packages/opentelemetry-metrics/src/export/types.ts b/packages/opentelemetry-metrics/src/export/types.ts
@@ -37,14 +37,14 @@ export interface Distribution {
   sum: number;
 }
 
-export type Histogram = {
+export interface Histogram {
   buckets: {
     boundaries: number[];
     counts: number[];
   };
   sum: number;
   count: number;
-};
+}
 
 export interface MetricRecord {
   readonly descriptor: MetricDescriptor;