fix: rename _finishTime to _endTime

open-telemetry · Jul 27, 2019 · 0d420cf · 0d420cf
1 parent 763dc2b
commit 0d420cf
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 4 deletions.
diff --git a/packages/opentelemetry-basic-tracer/src/Span.ts b/packages/opentelemetry-basic-tracer/src/Span.ts
@@ -41,7 +41,7 @@ export class Span implements types.Span {
   private _name: string;
   private _ended = false;
   private _startTime: number;
-  private _finishTime = 0;
+  private _endTime = 0;
 
   /** Constructs a new Span instance. */
   constructor(
@@ -115,7 +115,7 @@ export class Span implements types.Span {
   end(endTime?: number): void {
     if (this._isSpanEnded()) return;
     this._ended = true;
-    this._finishTime = endTime || performance.now();
+    this._endTime = endTime || performance.now();
     // @todo: record or export the span
   }
 
@@ -132,7 +132,7 @@ export class Span implements types.Span {
       kind: this._kind,
       status: this._status,
       startTime: this._startTime,
-      finishTime: this._finishTime,
+      endTime: this._endTime,
     });
     return `Span${json}`;
   }

diff --git a/packages/opentelemetry-basic-tracer/test/Span.test.ts b/packages/opentelemetry-basic-tracer/test/Span.test.ts
@@ -95,7 +95,7 @@ describe('Span', () => {
 
     assert.strictEqual(
       span.toString(),
-      `Span{"traceId":"${context.traceId}","spanId":"${context.spanId}","name":"${name}","kind":1,"status":{"code":0},"startTime":100,"finishTime":0}`
+      `Span{"traceId":"${context.traceId}","spanId":"${context.spanId}","name":"${name}","kind":1,"status":{"code":0},"startTime":100,"endTime":0}`
     );
   });
 });