Skip to content

Commit

Permalink
feat: enable dns instrumentation by default (#1543)
Browse files Browse the repository at this point in the history
also updates README to reflect the change, while adding links to hapi
and koa instrumentation that were missing

Co-authored-by: Daniel Dyla <dyladan@users.noreply.github.com>
  • Loading branch information
Naseem and dyladan committed Sep 22, 2020
1 parent 932d539 commit 9b3ff19
Show file tree
Hide file tree
Showing 2 changed files with 6 additions and 1 deletion.
6 changes: 5 additions & 1 deletion README.md
Original file line number Diff line number Diff line change
Expand Up @@ -198,7 +198,9 @@ These plugins are hosted at <https://github.com/open-telemetry/opentelemetry-js-
- [@opentelemetry/plugin-redis][otel-contrib-plugin-redis]
- [@opentelemetry/plugin-ioredis][otel-contrib-plugin-ioredis]
- [@opentelemetry/plugin-express][otel-contrib-plugin-express]
- [@opentelemetry/plugin-dns][otel-contrib-plugin-dns] - By default, this plugin is not loaded [#612](https://github.com/open-telemetry/opentelemetry-js/issues/612)
- [@opentelemetry/plugin-dns][otel-contrib-plugin-dns]
- [@opentelemetry/hapi-instrumentation][otel-contrib-hapi-instrumentation]
- [@opentelemetry/koa-instrumentation][otel-contrib-koa-instrumentation]

#### Web Plugins

Expand Down Expand Up @@ -265,3 +267,5 @@ Apache 2.0 - See [LICENSE][license-url] for more information.
[otel-contrib-plugin-express]: https://github.com/open-telemetry/opentelemetry-js-contrib/tree/master/plugins/node/opentelemetry-plugin-express
[otel-contrib-plugin-user-interaction]: https://github.com/open-telemetry/opentelemetry-js-contrib/tree/master/plugins/web/opentelemetry-plugin-user-interaction
[otel-contrib-plugin-document-load]: https://github.com/open-telemetry/opentelemetry-js-contrib/tree/master/plugins/web/opentelemetry-plugin-document-load
[otel-contrib-hapi-instrumentation]: https://github.com/open-telemetry/opentelemetry-js-contrib/tree/master/plugins/node/opentelemetry-hapi-instrumentation
[otel-contrib-koa-instrumentation]: https://github.com/open-telemetry/opentelemetry-js-contrib/tree/master/plugins/node/opentelemetry-koa-instrumentation
1 change: 1 addition & 0 deletions packages/opentelemetry-node/src/config.ts
Original file line number Diff line number Diff line change
Expand Up @@ -40,4 +40,5 @@ export const DEFAULT_INSTRUMENTATION_PLUGINS: Plugins = {
express: { enabled: true, path: '@opentelemetry/plugin-express' },
'@hapi/hapi': { enabled: true, path: '@opentelemetry/hapi-instrumentation' },
koa: { enabled: true, path: '@opentelemetry/koa-instrumentation' },
dns: { enabled: true, path: '@opentelemetry/plugin-dns' },
};

0 comments on commit 9b3ff19

Please sign in to comment.