chore: move MockedResponse to nodeHelper

open-telemetry · Oct 24, 2020 · a2600de · a2600de
1 parent af95af1
commit a2600de
Show file tree

Hide file tree

Showing 4 changed files with 38 additions and 23 deletions.
diff --git a/packages/opentelemetry-exporter-collector/test/helper.ts b/packages/opentelemetry-exporter-collector/test/helper.ts
@@ -22,7 +22,6 @@ import { InstrumentationLibrary } from '@opentelemetry/core';
 import * as assert from 'assert';
 import { opentelemetryProto } from '../src/types';
 import * as collectorTypes from '../src/types';
-import { Stream } from 'stream';
 
 const meterProvider = new MeterProvider({
   interval: 30000,
@@ -667,22 +666,3 @@ export function ensureHeadersContain(
     );
   });
 }
-
-export class MockedResponse extends Stream {
-  constructor(private _code: number, private _msg?: string) {
-    super();
-  }
-
-  send(data: string) {
-    this.emit('data', data);
-    this.emit('end');
-  }
-
-  get statusCode() {
-    return this._code;
-  }
-
-  get statusMessage() {
-    return this._msg;
-  }
-}
diff --git a/packages/opentelemetry-exporter-collector/test/node/CollectorMetricExporter.test.ts b/packages/opentelemetry-exporter-collector/test/node/CollectorMetricExporter.test.ts
@@ -22,7 +22,7 @@ import * as sinon from 'sinon';
 import { CollectorMetricExporter } from '../../src/platform/node';
 import { CollectorExporterConfigBase } from '../../src/types';
 import * as collectorTypes from '../../src/types';
-
+import { MockedResponse } from './nodeHelper';
 import {
   mockCounter,
   mockObserver,
@@ -31,7 +31,6 @@ import {
   mockValueRecorder,
   ensureValueRecorderIsCorrect,
   ensureObserverIsCorrect,
-  MockedResponse,
 } from '../helper';
 import { MetricRecord } from '@opentelemetry/metrics';
 

diff --git a/packages/opentelemetry-exporter-collector/test/node/CollectorTraceExporter.test.ts b/packages/opentelemetry-exporter-collector/test/node/CollectorTraceExporter.test.ts
@@ -23,7 +23,7 @@ import * as sinon from 'sinon';
 import { CollectorTraceExporter } from '../../src/platform/node';
 import { CollectorExporterConfigBase } from '../../src/types';
 import * as collectorTypes from '../../src/types';
-import { MockedResponse } from '../helper';
+import { MockedResponse } from './nodeHelper';
 
 import {
   ensureExportTraceServiceRequestIsSet,

diff --git a/packages/opentelemetry-exporter-collector/test/node/nodeHelpers.ts b/packages/opentelemetry-exporter-collector/test/node/nodeHelpers.ts
@@ -0,0 +1,36 @@
+/*
+ * Copyright The OpenTelemetry Authors
+ *
+ * Licensed under the Apache License, Version 2.0 (the "License");
+ * you may not use this file except in compliance with the License.
+ * You may obtain a copy of the License at
+ *
+ *      https://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+import { Stream } from 'stream';
+
+export class MockedResponse extends Stream {
+  constructor(private _code: number, private _msg?: string) {
+    super();
+  }
+
+  send(data: string) {
+    this.emit('data', data);
+    this.emit('end');
+  }
+
+  get statusCode() {
+    return this._code;
+  }
+
+  get statusMessage() {
+    return this._msg;
+  }
+}