Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add baggage support to the opentracing shim #329

Closed
bg451 opened this issue Sep 24, 2019 · 2 comments · Fixed by #918
Closed

Add baggage support to the opentracing shim #329

bg451 opened this issue Sep 24, 2019 · 2 comments · Fixed by #918

Comments

@bg451
Copy link
Member

bg451 commented Sep 24, 2019

Baggage isn't truly support with the OpenTracing shim. Currently setBaggage just applies the baggage item as an attribute to the span and that's it. I think that there's a few ways to split this problem up, the first being in process baggage propagation. Basically if I set a baggage item on span A, then create a child span B and C, that baggage item should be attached to B and C. I think in process baggage can be thrown in the SpanContextShim, and whenever a new span is created check the SpanContextShim for items and apply it to the new span.

The second bit is ensuring that baggage items go into the DistributedContext so out of band baggage propagation works.

@bg451 bg451 added feature-request up-for-grabs Good for taking. Extra help will be provided by maintainers labels Sep 24, 2019
@mayurkale22 mayurkale22 added this to the Alpha v0.2 milestone Oct 3, 2019
@mayurkale22 mayurkale22 modified the milestones: Alpha v0.2, Alpha v0.3 Oct 11, 2019
@mayurkale22 mayurkale22 modified the milestones: Alpha v0.3, Alpha v0.4 Nov 20, 2019
@mayurkale22 mayurkale22 modified the milestones: Alpha v0.4, Beta Feb 12, 2020
@rubenvp8510
Copy link
Contributor

I would like to work on this one, if no one else if already working on it.

@vmarchaud vmarchaud removed the up-for-grabs Good for taking. Extra help will be provided by maintainers label Feb 25, 2020
@vmarchaud
Copy link
Member

@rubenvp8510 Go for it, don't hesitate to ping on the gitter room if you have any questions

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
GA Burndown
  
Done
Development

Successfully merging a pull request may close this issue.

5 participants