Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(shim-opentracing): add propagator configuration #2153

Merged
merged 3 commits into from
Apr 29, 2021

Conversation

vreynolds
Copy link
Contributor

@vreynolds vreynolds commented Apr 23, 2021

Which problem is this PR solving?

Short description of the changes

  • optional propagator config based on new spec
    • leaving binary format as is, since that's not (yet?) specified in the spec
    • existing behavior: unknown format is a NOOP
    • changes are additive (non-breaking)
  • remove outdated note from readme: Add baggage support to the opentracing shim #329
  • fix jsdoc links: import was changed from types --> api

* optional propagator config based on new spec
* remove outdated note from readme
* fix jsdoc links
@codecov
Copy link

codecov bot commented Apr 23, 2021

Codecov Report

Merging #2153 (beb1449) into main (677727b) will increase coverage by 0.02%.
The diff coverage is 77.77%.

❗ Current head beb1449 differs from pull request most recent head 3dee4e5. Consider uploading reports for the commit 3dee4e5 to get more accurate results

@@            Coverage Diff             @@
##             main    #2153      +/-   ##
==========================================
+ Coverage   92.77%   92.80%   +0.02%     
==========================================
  Files         140      140              
  Lines        4997     5002       +5     
  Branches     1028     1029       +1     
==========================================
+ Hits         4636     4642       +6     
+ Misses        361      360       -1     
Impacted Files Coverage Δ
...ackages/opentelemetry-shim-opentracing/src/shim.ts 89.68% <77.77%> (+2.07%) ⬆️
...emetry-core/src/platform/node/RandomIdGenerator.ts 87.50% <0.00%> (-6.25%) ⬇️

Copy link
Member

@vmarchaud vmarchaud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

* bump propagators to latest version
* nullish coalescing instead of if/else
Copy link
Member

@obecny obecny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@vmarchaud vmarchaud merged commit 7b1ed39 into open-telemetry:main Apr 29, 2021
@vreynolds vreynolds deleted the ot-shim-propagator-config branch April 29, 2021 15:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants