Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

circle ci fails for gts 2.0.0 #959

Closed
obecny opened this issue Apr 10, 2020 · 4 comments
Closed

circle ci fails for gts 2.0.0 #959

obecny opened this issue Apr 10, 2020 · 4 comments
Labels
bug Something isn't working

Comments

@obecny
Copy link
Member

obecny commented Apr 10, 2020 •
edited
Loading

We are using gts version 1.1.0, but on circle ci gts didn't have version and recently was updated to ver. 2.0.0. There were problems with that and lerna couldn't boostrap dependency correctly. I did a fix to use the same version we use in our packages (1.1.0) but this should be investigated separately to see if we want to use latest version and then probably update circle ci config file as well as all packages to use new gts version.
The fix is done in this PR
#958
@obecny obecny added the bug Something isn't working label Apr 10, 2020
@obecny
Copy link
Member Author

obecny commented Apr 10, 2020

@dyladan, @mayurkale22 ^^

@mayurkale22
Copy link
Member

See: https://github.com/google/gts/blob/master/CHANGELOG.md#-breaking-changes-

@dyladan
Copy link
Member

dyladan commented Apr 11, 2020

there was already something on this: #891 #892 but the PR is still in draft. Oliver was waiting for the new gts to release. Now that it is ready he can probably get this going.

@dyladan
Copy link
Member

dyladan commented Apr 11, 2020

Closing as a duplicate of #891

@dyladan dyladan closed this as completed Apr 11, 2020
pichlermarc pushed a commit to dynatrace-oss-contrib/opentelemetry-js that referenced this issue Dec 15, 2023
@rauno56
chore: skip peer checking on packages that look like examples (open-t…
670797a 
…elemetry#959)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@obecny @dyladan @mayurkale22