Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: adding example for collector-exporter for node with opentelemetry-collector #958

Merged
merged 18 commits into from
Apr 14, 2020

Conversation

obecny
Copy link
Member

@obecny obecny commented Apr 10, 2020

Adding example for easier testing for collector-exporter with opentelemetry-collector using the latest image that supports new proto format with grpc

@obecny obecny self-assigned this Apr 10, 2020
@obecny obecny added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Apr 10, 2020
@codecov-io
Copy link

codecov-io commented Apr 10, 2020

Codecov Report

Merging #958 into master will increase coverage by 0.68%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master     #958      +/-   ##
==========================================
+ Coverage   94.75%   95.44%   +0.68%     
==========================================
  Files         248       84     -164     
  Lines       11288     5044    -6244     
  Branches     1079      495     -584     
==========================================
- Hits        10696     4814    -5882     
+ Misses        592      230     -362     
Impacted Files Coverage Δ
...ackages/opentelemetry-shim-opentracing/src/shim.ts
...lugin-xml-http-request/src/enums/AttributeNames.ts
packages/opentelemetry-core/src/common/time.ts
...y-plugin-document-load/src/enums/AttributeNames.ts
packages/opentelemetry-api/src/metrics/Metric.ts
packages/opentelemetry-metrics/src/types.ts
...pentelemetry-core/test/internal/validators.test.ts
packages/opentelemetry-api/src/version.ts
...ages/opentelemetry-plugin-mysql/test/mysql.test.ts
...kages/opentelemetry-exporter-jaeger/src/version.ts
... and 154 more

@dyladan
Copy link
Member

dyladan commented Apr 10, 2020

gts install is failing because typescript isn't installed first it looks like. Might have to do it in two separate npm install steps

examples/collector-exporter-node/README.md Outdated Show resolved Hide resolved
examples/collector-exporter-node/package.json Outdated Show resolved Hide resolved
examples/collector-exporter-node/start.js Outdated Show resolved Hide resolved
.circleci/config.yml Outdated Show resolved Hide resolved
@obecny
Copy link
Member Author

obecny commented Apr 13, 2020

is this ready to merge ?

@vmarchaud
Copy link
Member

I think we should merge this one first to rebase every other PR

@mayurkale22 mayurkale22 merged commit 8e56923 into open-telemetry:master Apr 14, 2020
@obecny obecny deleted the ec_example branch October 1, 2020 14:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants