Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove Bound Observer #997

Closed
dyladan opened this issue Apr 29, 2020 · 0 comments · Fixed by #1001
Closed

Remove Bound Observer #997

dyladan opened this issue Apr 29, 2020 · 0 comments · Fixed by #1001
Projects
Metrics API and SDK

Comments

@dyladan
Copy link
Member

dyladan commented Apr 29, 2020

This is not a bug as there should in fact be no concept of a "Bound Observer" according to the spec
https://github.com/open-telemetry/oteps/blob/master/text/0072-metric-observer.md#observer-calling-conventions

There is no equivalent of a "bound" observer instrument as there is with Counter, Gauge, and Measure instruments.

Closing this and opening an issue to remove the bound observer.

Originally posted by @dyladan in #994 (comment)
@dyladan dyladan added this to Needs triage in Bug Tracker via automation Apr 29, 2020
@dyladan dyladan moved this from Needs triage to Low priority in Bug Tracker Apr 29, 2020
@legendecas legendecas mentioned this issue Apr 30, 2020
Merged
@dyladan dyladan added this to Triage in Metrics API and SDK via automation Apr 30, 2020
@dyladan dyladan removed this from Low priority in Bug Tracker Apr 30, 2020
Metrics API and SDK automation moved this from Triage to Done May 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
No open projects
Metrics API and SDK
  
Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: observers should not expose bind/unbind method legendecas/opentelemetry-js
1 participant
@dyladan