Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(metrics): bound observers' value not been updated #994

Closed
wants to merge 1 commit into from

Conversation

legendecas
Copy link
Member

@legendecas legendecas commented Apr 29, 2020

Which problem is this PR solving?

  • bound observer's value not been updated, i.e. observer function not been called.

Short description of the changes

  • bound observers' observer result should be inherited from its original observer and been updated along with ObserverMetric.

@codecov-io
Copy link

codecov-io commented Apr 29, 2020

Codecov Report

Merging #994 into master will increase coverage by 0.03%.
The diff coverage is 96.96%.

@@            Coverage Diff             @@
##           master     #994      +/-   ##
==========================================
+ Coverage   94.90%   94.94%   +0.03%     
==========================================
  Files         212      212              
  Lines        8676     8701      +25     
  Branches      791      790       -1     
==========================================
+ Hits         8234     8261      +27     
+ Misses        442      440       -2     
Impacted Files Coverage Δ
packages/opentelemetry-metrics/src/Metric.ts 96.87% <ø> (ø)
...ckages/opentelemetry-metrics/src/ObserverResult.ts 92.85% <85.71%> (-7.15%) ⬇️
...kages/opentelemetry-metrics/src/BoundInstrument.ts 100.00% <100.00%> (+7.14%) ⬆️
packages/opentelemetry-metrics/test/Meter.test.ts 99.39% <100.00%> (+0.03%) ⬆️

bound observers' observer result should be inherited from its original
observer.
@dyladan dyladan added the bug Something isn't working label Apr 29, 2020
@dyladan
Copy link
Member

dyladan commented Apr 29, 2020

This is not a bug as there should in fact be no concept of a "Bound Observer" according to the spec
https://github.com/open-telemetry/oteps/blob/master/text/0072-metric-observer.md#observer-calling-conventions

There is no equivalent of a "bound" observer instrument as there is with Counter, Gauge, and Measure instruments.

Closing this and opening an issue to remove the bound observer.

@dyladan dyladan closed this Apr 29, 2020
@dyladan dyladan mentioned this pull request Apr 29, 2020
@legendecas legendecas deleted the observer branch May 7, 2020 08:36
pichlermarc pushed a commit to dynatrace-oss-contrib/opentelemetry-js that referenced this pull request Dec 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants