fix: observers should not expose bind/unbind method #1001
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
legendecas
requested review from
bg451,
dyladan,
markwolff,
mayurkale22,
obecny,
OlivierAlbertini,
rochdev and
vmarchaud
as code owners
Codecov Report
@@ Coverage Diff @@
## master #1001 +/- ##
==========================================
+ Coverage 95.00% 95.04% +0.04%
==========================================
Files 212 212
Lines 8813 8806 -7
Branches 796 796
==========================================
- Hits 8373 8370 -3
+ Misses 440 436 -4
|
legendecas
force-pushed
the
remove-observer-bind
branch
3 times, most recently
from
0b4c2c6
to
317db95
Compare
dyladan
reviewed
Apr 30, 2020
dyladan
reviewed
Apr 30, 2020
dyladan
reviewed
Apr 30, 2020
dyladan
reviewed
Apr 30, 2020
dyladan
approved these changes
May 4, 2020
mayurkale22
approved these changes
May 4, 2020
| clear(): void; | ||
| } | ||
|
|
||
| export interface UnboundMetric<T> extends Metric { |
There was a problem hiding this comment.
minor: pls add JSDoc comment.
legendecas
force-pushed
the
remove-observer-bind
branch
from
1851d3c
to
ccff588
Compare
legendecas
force-pushed
the
remove-observer-bind
branch
from
ccff588
to
6965c9a
Compare
legendecas
force-pushed
the
remove-observer-bind
branch
from
6965c9a
to
bfc2fb1
Compare
legendecas
force-pushed
the
remove-observer-bind
branch
from
b8823a2
to
bfc2fb1
Compare
dyladan
added
the
Merge:LGTM
dyladan
pushed a commit
to dyladan/opentelemetry-js
that referenced
this pull request
Sep 9, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which problem is this PR solving?
Short description of the changes
@opentelemetry/api: Add new interface UnboundMetric, with bind/unbind method, which extends Metric.@opentelemetry/metrics: Removed problematic setCallback method from BoundObserver. BoundObsever now acts as merely an instrument hold values, should not be exposed as public API.