fix(exporter-collector): default endpoint

[mayurkale22]

• This has been tested locally and confirmed to be working.

• Current example (collector-exporter-node) works well because we override the url address here.

• You would not see traces in backend if you rely on default url (i.e: http://localhost:55678/v1/trace).

/cc @obecny

[obecny]

has the url of opentelemetry-collector endpoint changed ?

[obecny]

Collector shares the same url between web and node, before grpc the url was fine for both, but now the node has different url the one you changed, whereas the web is still using the old one. This way maybe we should have platform specific default url. Otherwise the new url will not work in web now - so for anyone that uses the web without providing url it won't be working.

[obecny]

because of shared url people might put a protocol in front of url and it won't be working - hard to find out why. That's why I added removeProtocol here to avoid such situation - I would keep it

[mayurkale22]

Collector shares the same url between web and node, before grpc the url was fine for both, but now the node has different url the one you changed, whereas the web is still using the old one. This way maybe we should have platform specific default url. Otherwise the new url will not work in web now - so for anyone that uses the web without providing url it won't be working.

Hmmm good point. I tried the example with current url and failed to export data to backend via collector in the Node. I think we should use http://localhost:55678/v1/trace for Web and localhost:55678 for Node. This is what we have done in OpenCensus. Any thoughts?

[obecny]

Collector shares the same url between web and node, before grpc the url was fine for both, but now the node has different url the one you changed, whereas the web is still using the old one. This way maybe we should have platform specific default url. Otherwise the new url will not work in web now - so for anyone that uses the web without providing url it won't be working.

Hmmm good point. I tried the example with current url and failed to export data to backend via collector in the Node. I think we should use http://localhost:55678/v1/trace for Web and localhost:55678 for Node. This is what we have done in OpenCensus. Any thoughts?

constants.ts in platform folder with DEFAULT_URL ?

[obecny]

@mayurkale22 after this PR is merged -> #1063
changing the url to be platform dependent should be easier

[dyladan]

#1063 is merged now, so this can be updated with the platform-specific constants

[mayurkale22]

#1063 is merged now, so this can be updated with the platform-specific constants

Will take care of this sometime today.

[mayurkale22]

Not sure how it got closed (I was trying to rebase with master). Anyways, will open new PR.