Adds possibility to set headers to zipkin exporter #1202
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
obecny
requested review from
bg451,
dyladan,
markwolff,
mayurkale22,
mwear,
naseemkullah,
OlivierAlbertini,
rochdev and
vmarchaud
as code owners
obecny
added
size/S
dyladan
approved these changes
Jun 16, 2020
Codecov Report
@@ Coverage Diff @@
## master #1202 +/- ##
=======================================
Coverage 92.32% 92.32%
=======================================
Files 122 122
Lines 3533 3533
Branches 714 714
=======================================
Hits 3262 3262
Misses 271 271
|
mayurkale22
approved these changes
Jun 17, 2020
|
It would be nice if you can update the Usage section in Readme (https://github.com/open-telemetry/opentelemetry-js/blob/master/packages/opentelemetry-exporter-zipkin/README.md) to highlight this new option, otherwise there is no easy way for new users to know about this option. |
mayurkale22
approved these changes
Jun 17, 2020
|
/cc @astorm |
markwolff
approved these changes
Jun 17, 2020
dyladan
added
the
Merge:LGTM
pichlermarc
pushed a commit
to dynatrace-oss-contrib/opentelemetry-js
that referenced
this pull request
Dec 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which problem is this PR solving?
Short description of the changes