Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: 0.9.0 release proposal #1208

Merged
merged 8 commits into from
Jun 18, 2020

Conversation

mayurkale22
Copy link
Member

@mayurkale22 mayurkale22 commented Jun 17, 2020

@dyladan
Copy link
Member

dyladan commented Jun 17, 2020

missing node-all, examples, and getting started

CHANGELOG.md Outdated Show resolved Hide resolved
@mayurkale22
Copy link
Member Author

missing node-all, examples, and getting started

done.

@dyladan
Copy link
Member

dyladan commented Jun 17, 2020

Still don't see plugins-node-all. Looks like your branch is out of date so possible you just started making this before I merged the PR?

@codecov
Copy link

codecov bot commented Jun 17, 2020

Codecov Report

Merging #1208 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #1208   +/-   ##
=======================================
  Coverage   92.32%   92.32%           
=======================================
  Files         122      122           
  Lines        3533     3533           
  Branches      714      714           
=======================================
  Hits         3262     3262           
  Misses        271      271           

Copy link
Member

@mwear mwear left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One typo, but otherwise LGTM!

CHANGELOG.md Show resolved Hide resolved
@obecny
Copy link
Member

obecny commented Jun 17, 2020

this is tiny but important fix, would be good to include it in this release as then it is also needed in next fix in user_interaction plugin
#1209

@mayurkale22
Copy link
Member Author

this is tiny but important fix, would be good to include it in this release as then it is also needed in next fix in user_interaction plugin
#1209

Sure, will wait for #1209 and if possible, #1202 and #1204

@mayurkale22
Copy link
Member Author

@open-telemetry/javascript-approvers This is ready to land now, please take a look one more time.

@mayurkale22 mayurkale22 merged commit 904245f into open-telemetry:master Jun 18, 2020
@mayurkale22 mayurkale22 deleted the 0.9.0-proposal branch June 18, 2020 21:20
dyladan pushed a commit to dyladan/opentelemetry-js that referenced this pull request Sep 9, 2022
dyladan pushed a commit to dyladan/opentelemetry-js that referenced this pull request Sep 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants