feat: zipkin in web #1265

[Booster2ooo]

Which problem is this PR solving?

Zipkin in web #1265,

Short description of the changes

Refactored for browser compatibility in addition to nodejs

• Moved current zipkin exporter implementation in /src/platform/node
• Created a new zipkin exporter using fetch instead of node http/https apis
• Add package.json browser field

/!\ Lacks testing

[linux-foundation-easycla]

The committers are authorized under a signed CLA.

• ✅ Booster2ooo (43c6fa4)

[codecov]

Codecov Report

Merging #1393 into master will not change coverage.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master    #1393   +/-   ##
=======================================
  Coverage   94.03%   94.03%           
=======================================
  Files         149      149           
  Lines        4322     4322           
  Branches      880      880           
=======================================
  Hits         4064     4064           
  Misses        258      258           

Impacted Files	Coverage Δ
...emetry-exporter-zipkin/src/platform/node/zipkin.ts	98.46% <100.00%> (ø)
...ges/opentelemetry-exporter-zipkin/src/transform.ts	100.00% <100.00%> (ø)

[dyladan]

browser on its own line please.

Why is this a different platform configuration style than our other packages?

[Booster2ooo]

Agreed for the new line.

I don't understand the issue with the "different style than the other packages", could you elaborate please ? I took @opentelemetry/exporter-collector as an exemple.

[dyladan]

missing header

please add a newline at the end of the file

[dyladan]

This is almost the same as the node version, but is completely copied. Is there no way to use a base class to share functionality?

[obecny]

You should refactor zipkin in a way that only sendmethod should be extracted and defined in platform. For web you should use XMLHttpRequest not fetch but default method should be sendBeacon with a fallback to XMLHttpRequest if user defines any headers. You can check the ExporterCollector how it is done and I think it should have similar styling / approach here, thx

[obecny]

Have you checked that the issue you are trying to resolve has been assigned ?

[Booster2ooo]

Have you checked that the issue you are trying to resolve has been assigned ?

Yes, I did see it was assigned to you @obecny but I thought I could help. I hope this doesn't go against the contributing guidelines. I must admit I'm not very familiar with collaboration so I'm sorry if I crossed any line.

[obecny]

Have you checked that the issue you are trying to resolve has been assigned ?

Yes, I did see it was assigned to you @obecny but I thought I could help. I hope this doesn't go against the contributing guidelines. I must admit I'm not very familiar with collaboration so I'm sorry if I crossed any line.

I was working on this already and almost finished

[Booster2ooo]

Have you checked that the issue you are trying to resolve has been assigned ?

Yes, I did see it was assigned to you @obecny but I thought I could help. I hope this doesn't go against the contributing guidelines. I must admit I'm not very familiar with collaboration so I'm sorry if I crossed any line.

I was working on this already and almost finished

Sorry I overstepped (even if I'm happy I did because I'm learning doing so :)), I guess your PR will probably be way more qualitative. I'll probably try to implement the improvements you and dyladan raised, just for my own sake, but this PR can bit ignored/closed I assume.

[obecny]

Have you checked that the issue you are trying to resolve has been assigned ?

Yes, I did see it was assigned to you @obecny but I thought I could help. I hope this doesn't go against the contributing guidelines. I must admit I'm not very familiar with collaboration so I'm sorry if I crossed any line.

I was working on this already and almost finished

Sorry I overstepped (even if I'm happy I did because I'm learning doing so :)), I guess your PR will probably be way more qualitative. I'll probably try to implement the improvements you and dyladan raised, just for my own sake, but this PR can bit ignored/closed I assume.

No worries :), we are always happy to welcome people who wants to contribute. There are many opened issues which are not assigned to anyone, maybe you could have a look at them and see if anything sounds interesting for you (don't feel being pushed) and if so you can comment on that issue so we can assign it to you to avoid duplication of work.
With regards to zipkin itself I have already published my PR with changes.
thx