Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: simplify active span logic #1589

Merged
merged 4 commits into from
Oct 14, 2020
Merged

feat: simplify active span logic #1589

merged 4 commits into from
Oct 14, 2020

Commits on Oct 14, 2020

  1. refactor!: wrap extracted span context in span on extract

    @mwear
    mwear committed Oct 14, 2020
    Configuration menu
    Copy the full SHA
    1d32c92 View commit details
    Browse the repository at this point in the history

  2. fix: preserve require parent logic with wrapped extracted span context

    @mwear
    mwear committed Oct 14, 2020
    Configuration menu
    Copy the full SHA
    2c707f7 View commit details
    Browse the repository at this point in the history

  3. refactor!: remove getExtractedSpanContext 

    This method doesn't really make sense since we wrap a span context
in a span on extract. Getting the context from the current span
is preferred replacement.
    @mwear
    mwear committed Oct 14, 2020
    Configuration menu
    Copy the full SHA
    4c5cee6 View commit details
    Browse the repository at this point in the history

  4. Update packages/opentelemetry-api/src/context/context.ts 

    Co-authored-by: Bartlomiej Obecny <bobecny@gmail.com>
    @mwear @obecny
    mwear and obecny committed Oct 14, 2020
    Configuration menu
    Copy the full SHA
    feb1fcc View commit details
    Browse the repository at this point in the history