Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove ordered attribute dropping #1685

Merged
merged 6 commits into from
Dec 14, 2020

Conversation

dyladan
Copy link
Member

@dyladan dyladan commented Nov 18, 2020

In open-telemetry/opentelemetry-specification#1212 the requirement to order attributes was dropped. The current specification simply states that if the maximum number of attributes is met, then additional attributes are dropped.

@dyladan dyladan added the enhancement New feature or request label Nov 18, 2020
@dyladan dyladan added this to In progress PRs in GA Burndown via automation Nov 18, 2020
@codecov
Copy link

codecov bot commented Nov 18, 2020

Codecov Report

Merging #1685 (62ef0e9) into master (b744f30) will decrease coverage by 0.00%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master    #1685      +/-   ##
==========================================
- Coverage   92.13%   92.13%   -0.01%     
==========================================
  Files         166      166              
  Lines        5592     5591       -1     
  Branches     1193     1194       +1     
==========================================
- Hits         5152     5151       -1     
  Misses        440      440              
Impacted Files Coverage Δ
packages/opentelemetry-tracing/src/Span.ts 98.07% <100.00%> (-0.02%) ⬇️

GA Burndown automation moved this from In progress PRs to Approved Dec 10, 2020
@obecny
Copy link
Member

obecny commented Dec 14, 2020

@dyladan pls update and fix the build - I can't trigger update

@obecny obecny merged commit 74d6e45 into open-telemetry:master Dec 14, 2020
GA Burndown automation moved this from Approved to Done Dec 14, 2020
@Flarna Flarna deleted the no-order-limits branch December 15, 2020 22:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
No open projects
GA Burndown
  
Done
Development

Successfully merging this pull request may close these issues.

None yet

3 participants