Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update API dependency to 1.0.0-rc.0 #2063

Merged
merged 1 commit into from Apr 5, 2021

Conversation

dyladan
Copy link
Member

@dyladan dyladan commented Mar 31, 2021

After downgrading to fix the backwards incompatibility with 0.18.1, this reverts the downgrade which may now be released as 0.19.0

@codecov
Copy link

codecov bot commented Mar 31, 2021

Codecov Report

Merging #2063 (aba592a) into main (853fcb9) will decrease coverage by 0.01%.
The diff coverage is n/a.

❗ Current head aba592a differs from pull request most recent head 4d34150. Consider uploading reports for the commit 4d34150 to get more accurate results

@@            Coverage Diff             @@
##             main    #2063      +/-   ##
==========================================
- Coverage   93.05%   93.03%   -0.02%     
==========================================
  Files         154      154              
  Lines        5975     5975              
  Branches     1246     1246              
==========================================
- Hits         5560     5559       -1     
- Misses        415      416       +1     
Impacted Files Coverage Δ
...emetry-core/src/platform/node/RandomIdGenerator.ts 87.50% <0.00%> (-6.25%) ⬇️

Copy link
Member

@vmarchaud vmarchaud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should we use this opportunity to move api to peerDeps ?

@dyladan
Copy link
Member Author

dyladan commented Mar 31, 2021

should we use this opportunity to move api to peerDeps ?

Probably one thing at a time

@dyladan
Copy link
Member Author

dyladan commented Mar 31, 2021

I can't figure out the @types/hapi_hapi compilation error and it's driving me crazy. Versions are pinned so I know it's not getting an updated version and I've been working on this for an hour now and getting nowhere. Very frustrating.

@vmarchaud
Copy link
Member

I can't figure out the @types/hapi_hapi compilation error and it's driving me crazy. Versions are pinned so I know it's not getting an updated version and I've been working on this for an hour now and getting nowhere. Very frustrating.

Even though we are talking about a different PR, i think you can tell TS to ignore lib types with skipLibCheck

@dyladan
Copy link
Member Author

dyladan commented Mar 31, 2021

Even though we are talking about a different PR

👀 oops. I guess I didn't notice I was on the wrong PR. Thanks for the suggestion though

@dyladan dyladan merged commit 02175df into open-telemetry:main Apr 5, 2021
@dyladan dyladan deleted the api-rc branch April 5, 2021 16:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants