Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: 0.19.0 release proposal #2107

Merged
merged 8 commits into from
Apr 22, 2021
Merged

Conversation

dyladan
Copy link
Member

@dyladan dyladan commented Apr 13, 2021

💥 Breaking Change

  • opentelemetry-core, opentelemetry-tracing
  • opentelemetry-instrumentation-fetch, opentelemetry-instrumentation-grpc, opentelemetry-instrumentation-http, opentelemetry-instrumentation-xml-http-request, opentelemetry-semantic-conventions, opentelemetry-tracing, opentelemetry-web
    • #2083 feat: add semconv generator for semantic-conventions-package (@weyert)
  • opentelemetry-core, opentelemetry-grpc-utils, opentelemetry-instrumentation-fetch, opentelemetry-instrumentation-grpc, opentelemetry-instrumentation-http, opentelemetry-instrumentation-xml-http-request, opentelemetry-instrumentation, opentelemetry-node, opentelemetry-plugin-grpc-js, opentelemetry-plugin-grpc, opentelemetry-plugin-http, opentelemetry-plugin-https, opentelemetry-sdk-node, opentelemetry-web
  • opentelemetry-api-metrics, opentelemetry-context-async-hooks, opentelemetry-context-zone-peer-dep, opentelemetry-core, opentelemetry-exporter-collector-grpc, opentelemetry-exporter-collector-proto, opentelemetry-exporter-collector, opentelemetry-exporter-jaeger, opentelemetry-exporter-prometheus, opentelemetry-exporter-zipkin, opentelemetry-grpc-utils, opentelemetry-instrumentation-fetch, opentelemetry-instrumentation-grpc, opentelemetry-instrumentation-http, opentelemetry-instrumentation-xml-http-request, opentelemetry-instrumentation, opentelemetry-metrics, opentelemetry-node, opentelemetry-plugin-grpc-js, opentelemetry-plugin-grpc, opentelemetry-plugin-http, opentelemetry-plugin-https, opentelemetry-propagator-b3, opentelemetry-propagator-jaeger, opentelemetry-resource-detector-aws, opentelemetry-resource-detector-gcp, opentelemetry-resources, opentelemetry-sdk-node, opentelemetry-shim-opentracing, opentelemetry-tracing, opentelemetry-web
  • opentelemetry-core, opentelemetry-propagator-b3

🚀 (Enhancement)

  • opentelemetry-instrumentation
    • #2135 fix: add isEnabled to InstrumentationBase (@seemk)
  • opentelemetry-semantic-conventions
    • #2115 feat: upgrade semantic conventions to v1.2.0 of spec (@weyert)
  • opentelemetry-core, opentelemetry-exporter-zipkin
  • opentelemetry-exporter-zipkin
    • #2050 chore: adding interceptor for getting headers before each request (@obecny)
  • opentelemetry-exporter-collector-grpc
    • #2092 Migrate exporter-collector-grpc to grpc-js (@obecny)
  • opentelemetry-instrumentation-http
    • #2043 chore: avoid unneeded context.with in http instrumentation (@Flarna)
  • opentelemetry-instrumentation-fetch, opentelemetry-instrumentation-xml-http-request
    • #2061 chore: adding info to debug whenever headers are being skipped due to cors policy (@obecny)

🐛 (Bug Fix)

  • opentelemetry-exporter-prometheus
  • opentelemetry-instrumentation
    • #2120 fix(instrumentation): support multiple module definitions with different versions (@seemk)
  • opentelemetry-instrumentation-http, opentelemetry-tracing
  • opentelemetry-context-async-hooks
    • #2088 fix: correct removeAllListeners in case no event is passed (@Flarna)
  • opentelemetry-resource-detector-aws
  • opentelemetry-core, opentelemetry-propagator-b3, opentelemetry-propagator-jaeger
    • #2082 chore: do not inject span context when instrumentation is suppressed (@dyladan)
  • opentelemetry-core
  • opentelemetry-tracing
    • #2086 fix: exception.type should always be a string (@YanivD)
  • opentelemetry-propagator-jaeger
    • #1986 fix(propagator-jaeger): zero pad extracted trace id to 32 characters (@sid-maddy)

📚 (Refine Doc)

🏠 (Internal)

  • opentelemetry-exporter-collector-grpc, opentelemetry-metrics, opentelemetry-tracing
  • opentelemetry-context-zone, opentelemetry-core, opentelemetry-exporter-collector-grpc, opentelemetry-exporter-collector-proto, opentelemetry-exporter-collector, opentelemetry-exporter-jaeger, opentelemetry-exporter-prometheus, opentelemetry-exporter-zipkin, opentelemetry-instrumentation-fetch, opentelemetry-instrumentation-grpc, opentelemetry-instrumentation-http, opentelemetry-instrumentation-xml-http-request, opentelemetry-instrumentation, opentelemetry-metrics, opentelemetry-node, opentelemetry-propagator-jaeger, opentelemetry-resource-detector-aws, opentelemetry-resource-detector-gcp, opentelemetry-resources, opentelemetry-sdk-node, opentelemetry-shim-opentracing, opentelemetry-tracing, opentelemetry-web

Committers: 15

@codecov
Copy link

codecov bot commented Apr 13, 2021

Codecov Report

Merging #2107 (07a7821) into main (d3989d3) will increase coverage by 0.02%.
The diff coverage is n/a.

❗ Current head 07a7821 differs from pull request most recent head 6210cce. Consider uploading reports for the commit 6210cce to get more accurate results

@@            Coverage Diff             @@
##             main    #2107      +/-   ##
==========================================
+ Coverage   92.75%   92.77%   +0.02%     
==========================================
  Files         140      140              
  Lines        4981     4981              
  Branches     1028     1028              
==========================================
+ Hits         4620     4621       +1     
+ Misses        361      360       -1     
Impacted Files Coverage Δ
...emetry-core/src/platform/node/RandomIdGenerator.ts 93.75% <0.00%> (+6.25%) ⬆️

@Flarna
Copy link
Member

Flarna commented Apr 13, 2021

Should we do a API 1.0.0-rc.1 first which includes the breaking change open-telemetry/opentelemetry-js-api#32 first?

@vmarchaud
Copy link
Member

Should we do a API 1.0.0-rc.1 first which includes the breaking change open-telemetry/opentelemetry-js-api#32 first?

I would personaly prefer to do a first release without plugins and update this afterwards

@dyladan
Copy link
Member Author

dyladan commented Apr 14, 2021

We did the same with the API. We released a 0.x version, then immediately released a 1.0.0-rc.0

@Flarna
Copy link
Member

Flarna commented Apr 14, 2021

I'm fine with either way. Not sure anyway if breaking changes between -rc.0 and -rc.1 need to be really consider as breaking - they are dev versions.

@dyladan
Copy link
Member Author

dyladan commented Apr 19, 2021

@open-telemetry/javascript-approvers @open-telemetry/javascript-maintainers

Copy link
Member

@Flarna Flarna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some points to consider:

  • Update Compatibility Matrix in Readme
  • I think we should mention that API is now a peer dependency in upgrade guidelines of readme
  • Merge master + regenerate changelog

@dyladan
Copy link
Member Author

dyladan commented Apr 19, 2021

Some points to consider:

  • Update Compatibility Matrix in Readme
  • I think we should mention that API is now a peer dependency in upgrade guidelines of readme
  • Merge master + regenerate changelog

Done thanks

@obecny
Copy link
Member

obecny commented Apr 19, 2021

Some points to consider:

  • Update Compatibility Matrix in Readme
  • I think we should mention that API is now a peer dependency in upgrade guidelines of readme
  • Merge master + regenerate changelog

Done thanks

I can't see the readme.md changes, was this done in separate PR ?

@dyladan
Copy link
Member Author

dyladan commented Apr 19, 2021

Forgot to push 👎

@obecny
Copy link
Member

obecny commented Apr 19, 2021

  • I think we should mention that API is now a peer dependency in upgrade guidelines of readme

Correct me if I'm wrong but shouldn't we have then a peerDependencies section in each package.json that will point to api ?

Nevermind I see it was changed earlier

@dyladan dyladan merged commit 0c15999 into open-telemetry:main Apr 22, 2021
@dyladan dyladan deleted the 0.19.0-proposal branch April 22, 2021 12:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants