-
Notifications
You must be signed in to change notification settings - Fork 794
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: 0.19.0 release proposal #2107
Conversation
Codecov Report
@@ Coverage Diff @@
## main #2107 +/- ##
==========================================
+ Coverage 92.75% 92.77% +0.02%
==========================================
Files 140 140
Lines 4981 4981
Branches 1028 1028
==========================================
+ Hits 4620 4621 +1
+ Misses 361 360 -1
|
Should we do a API 1.0.0-rc.1 first which includes the breaking change open-telemetry/opentelemetry-js-api#32 first? |
I would personaly prefer to do a first release without plugins and update this afterwards |
We did the same with the API. We released a 0.x version, then immediately released a 1.0.0-rc.0 |
I'm fine with either way. Not sure anyway if breaking changes between -rc.0 and -rc.1 need to be really consider as breaking - they are dev versions. |
@open-telemetry/javascript-approvers @open-telemetry/javascript-maintainers |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some points to consider:
- Update Compatibility Matrix in Readme
- I think we should mention that API is now a peer dependency in upgrade guidelines of readme
- Merge master + regenerate changelog
Done thanks |
I can't see the |
Forgot to push 👎 |
Nevermind I see it was changed earlier |
💥 Breaking Change
opentelemetry-core
,opentelemetry-tracing
opentelemetry-instrumentation-fetch
,opentelemetry-instrumentation-grpc
,opentelemetry-instrumentation-http
,opentelemetry-instrumentation-xml-http-request
,opentelemetry-semantic-conventions
,opentelemetry-tracing
,opentelemetry-web
semantic-conventions
-package (@weyert)opentelemetry-core
,opentelemetry-grpc-utils
,opentelemetry-instrumentation-fetch
,opentelemetry-instrumentation-grpc
,opentelemetry-instrumentation-http
,opentelemetry-instrumentation-xml-http-request
,opentelemetry-instrumentation
,opentelemetry-node
,opentelemetry-plugin-grpc-js
,opentelemetry-plugin-grpc
,opentelemetry-plugin-http
,opentelemetry-plugin-https
,opentelemetry-sdk-node
,opentelemetry-web
opentelemetry-api-metrics
,opentelemetry-context-async-hooks
,opentelemetry-context-zone-peer-dep
,opentelemetry-core
,opentelemetry-exporter-collector-grpc
,opentelemetry-exporter-collector-proto
,opentelemetry-exporter-collector
,opentelemetry-exporter-jaeger
,opentelemetry-exporter-prometheus
,opentelemetry-exporter-zipkin
,opentelemetry-grpc-utils
,opentelemetry-instrumentation-fetch
,opentelemetry-instrumentation-grpc
,opentelemetry-instrumentation-http
,opentelemetry-instrumentation-xml-http-request
,opentelemetry-instrumentation
,opentelemetry-metrics
,opentelemetry-node
,opentelemetry-plugin-grpc-js
,opentelemetry-plugin-grpc
,opentelemetry-plugin-http
,opentelemetry-plugin-https
,opentelemetry-propagator-b3
,opentelemetry-propagator-jaeger
,opentelemetry-resource-detector-aws
,opentelemetry-resource-detector-gcp
,opentelemetry-resources
,opentelemetry-sdk-node
,opentelemetry-shim-opentracing
,opentelemetry-tracing
,opentelemetry-web
opentelemetry-core
,opentelemetry-propagator-b3
🚀 (Enhancement)
opentelemetry-instrumentation
opentelemetry-semantic-conventions
opentelemetry-core
,opentelemetry-exporter-zipkin
opentelemetry-exporter-zipkin
opentelemetry-exporter-collector-grpc
opentelemetry-instrumentation-http
opentelemetry-instrumentation-fetch
,opentelemetry-instrumentation-xml-http-request
🐛 (Bug Fix)
opentelemetry-exporter-prometheus
opentelemetry-instrumentation
opentelemetry-instrumentation-http
,opentelemetry-tracing
opentelemetry-context-async-hooks
opentelemetry-resource-detector-aws
opentelemetry-core
,opentelemetry-propagator-b3
,opentelemetry-propagator-jaeger
opentelemetry-core
opentelemetry-tracing
opentelemetry-propagator-jaeger
📚 (Refine Doc)
🏠 (Internal)
opentelemetry-exporter-collector-grpc
,opentelemetry-metrics
,opentelemetry-tracing
opentelemetry-context-zone
,opentelemetry-core
,opentelemetry-exporter-collector-grpc
,opentelemetry-exporter-collector-proto
,opentelemetry-exporter-collector
,opentelemetry-exporter-jaeger
,opentelemetry-exporter-prometheus
,opentelemetry-exporter-zipkin
,opentelemetry-instrumentation-fetch
,opentelemetry-instrumentation-grpc
,opentelemetry-instrumentation-http
,opentelemetry-instrumentation-xml-http-request
,opentelemetry-instrumentation
,opentelemetry-metrics
,opentelemetry-node
,opentelemetry-propagator-jaeger
,opentelemetry-resource-detector-aws
,opentelemetry-resource-detector-gcp
,opentelemetry-resources
,opentelemetry-sdk-node
,opentelemetry-shim-opentracing
,opentelemetry-tracing
,opentelemetry-web
Committers: 15