Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: do not inject invalid span context #2080

Merged

Conversation

dyladan
Copy link
Member

@dyladan dyladan commented Apr 7, 2021

Fixes #2066

@codecov
Copy link

codecov bot commented Apr 7, 2021

Codecov Report

Merging #2080 (35a69b8) into main (a457776) will decrease coverage by 0.05%.
The diff coverage is 100.00%.

❗ Current head 35a69b8 differs from pull request most recent head a93aed9. Consider uploading reports for the commit a93aed9 to get more accurate results

@@            Coverage Diff             @@
##             main    #2080      +/-   ##
==========================================
- Coverage   93.03%   92.98%   -0.06%     
==========================================
  Files         154      154              
  Lines        5976     5976              
  Branches     1246     1246              
==========================================
- Hits         5560     5557       -3     
- Misses        416      419       +3     
Impacted Files Coverage Δ
...y-core/src/context/propagation/HttpTraceContext.ts 100.00% <100.00%> (ø)
...etry-exporter-prometheus/src/PrometheusExporter.ts 90.66% <0.00%> (-1.34%) ⬇️
...ges/opentelemetry-instrumentation-http/src/http.ts 94.82% <0.00%> (-0.80%) ⬇️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

HttpTraceContext injects invalid span context
4 participants