Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate exporter-collector-grpc to grpc-js #2092

Merged
merged 5 commits into from
Apr 12, 2021
Merged

Conversation

obecny
Copy link
Member

@obecny obecny commented Apr 9, 2021

Which problem is this PR solving?

Short description of the changes

  • using grpc-js instead of grpc in exporter-collector-grpc
  • took a draft rebased, tested then fixed the error

grpc-js is compatible with

"node": "^8.13.0 || >=10.10.0"

I would say it should be fine, but I would like to know what other thinks ?

@codecov
Copy link

codecov bot commented Apr 9, 2021

Codecov Report

Merging #2092 (46375f3) into main (2260dd6) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #2092   +/-   ##
=======================================
  Coverage   92.73%   92.73%           
=======================================
  Files         137      137           
  Lines        4915     4915           
  Branches     1015     1015           
=======================================
  Hits         4558     4558           
  Misses        357      357           

@vmarchaud
Copy link
Member

grpc-js is compatible with
"node": "^8.13.0 || >=10.10.0"
I would say it should be fine, but I would like to know what other thinks ?

cc @dyladan since you have internal stats of dynatrace for this but i would say thats fine too since there are non-grpc exporter available (but we need to update the package.json engines field)

@obecny
Copy link
Member Author

obecny commented Apr 9, 2021

cc @dradetsky

@dyladan
Copy link
Member

dyladan commented Apr 12, 2021

I think it's fine as long as 8.5 customers have the ability to use the http exporter or something else and are not entirely locked out.

At some point we should consider dropping 8.x entirely

Copy link
Member

@dyladan dyladan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's really that easy?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Migrate exporter-collector-grpc to grpc-js
4 participants