Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: apply eslint rule semi #2710

Merged
merged 3 commits into from
Jan 11, 2022
Merged

Conversation

legendecas
Copy link
Member

Which problem is this PR solving?

  1. Enforce ending statements with semicolons.
  2. Enforce removing trailing spaces.
  3. Enforce EOF to be present.

Type of change

  • Bug fix (non-breaking change which fixes an issue)

Checklist:

  • Followed the style guidelines of this project

@legendecas legendecas requested a review from a team January 10, 2022 06:10
@codecov
Copy link

codecov bot commented Jan 10, 2022

Codecov Report

Merging #2710 (538c0e9) into main (4909cf1) will decrease coverage by 0.01%.
The diff coverage is 100.00%.

❗ Current head 538c0e9 differs from pull request most recent head 6c882b7. Consider uploading reports for the commit 6c882b7 to get more accurate results

@@            Coverage Diff             @@
##             main    #2710      +/-   ##
==========================================
- Coverage   93.05%   93.03%   -0.02%     
==========================================
  Files         155      155              
  Lines        5368     5368              
  Branches     1131     1131              
==========================================
- Hits         4995     4994       -1     
- Misses        373      374       +1     
Impacted Files Coverage Δ
...ckages/opentelemetry-exporter-zipkin/src/zipkin.ts 100.00% <ø> (ø)
packages/opentelemetry-resources/src/Resource.ts 100.00% <ø> (ø)
...ckages/opentelemetry-exporter-jaeger/src/jaeger.ts 94.59% <100.00%> (ø)
...emetry-core/src/platform/node/RandomIdGenerator.ts 87.50% <0.00%> (-6.25%) ⬇️

eslint.config.js Outdated Show resolved Hide resolved
@legendecas legendecas merged commit 82e39c4 into open-telemetry:main Jan 11, 2022
@legendecas legendecas deleted the semi branch January 11, 2022 16:07
rauno56 pushed a commit to rauno56/opentelemetry-js that referenced this pull request Jan 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants