Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: enforce consistent span durations #3327

Merged
merged 11 commits into from
Oct 17, 2022

Conversation

dyladan
Copy link
Member

@dyladan dyladan commented Oct 13, 2022

Related to #3279

Ensures span durations are never negative even when provided with inconsistent start and end times.

@codecov
Copy link

codecov bot commented Oct 13, 2022

Codecov Report

Merging #3327 (6b65b54) into main (3ab8bfc) will decrease coverage by 0.77%.
The diff coverage is 100.00%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3327      +/-   ##
==========================================
- Coverage   93.42%   92.65%   -0.78%     
==========================================
  Files         241      130     -111     
  Lines        7258     3130    -4128     
  Branches     1507      656     -851     
==========================================
- Hits         6781     2900    -3881     
+ Misses        477      230     -247     
Impacted Files Coverage Δ
packages/opentelemetry-sdk-trace-base/src/Span.ts 100.00% <100.00%> (+0.80%) ⬆️
api/src/platform/node/globalThis.ts 0.00% <0.00%> (-100.00%) ⬇️
...s/opentelemetry-core/src/platform/node/sdk-info.ts 0.00% <0.00%> (-100.00%) ⬇️
...opentelemetry-core/src/platform/node/globalThis.ts 0.00% <0.00%> (-100.00%) ⬇️
...pentelemetry-core/src/platform/node/performance.ts 0.00% <0.00%> (-100.00%) ⬇️
.../packages/api-logs/src/platform/node/globalThis.ts 0.00% <0.00%> (-100.00%) ⬇️
...emetry-api-metrics/src/platform/node/globalThis.ts 0.00% <0.00%> (-100.00%) ⬇️
...lemetry-resources/src/detectors/ProcessDetector.ts 31.81% <0.00%> (-68.19%) ⬇️
...perimental/packages/otlp-exporter-base/src/util.ts 78.94% <0.00%> (-15.79%) ⬇️
...ckages/opentelemetry-exporter-zipkin/src/zipkin.ts 84.48% <0.00%> (-15.52%) ⬇️
... and 115 more

Copy link
Member

@Flarna Flarna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess the unrelated changes in workflow files will be done in a separate PR.

@dyladan
Copy link
Member Author

dyladan commented Oct 17, 2022

I guess the unrelated changes in workflow files will be done in a separate PR.

yeah just needed this PR to pass tests

@dyladan dyladan merged commit ec8ff16 into open-telemetry:main Oct 17, 2022
@dyladan dyladan deleted the time-consistency branch October 17, 2022 21:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants