chore: add plugin developer guide #348
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mayurkale22
requested review from
bg451,
danielkhan,
iredelmeier,
OlivierAlbertini,
rochdev and
vmarchaud
as code owners
mayurkale22
force-pushed
the
plugin-doc
branch
from
702366c
to
c3065c6
Compare
OlivierAlbertini
approved these changes
Sep 26, 2019
There was a problem hiding this comment.
Nice! Should we provide a link related to our tests (where we create some fake plugins) ? This could help people to understand how it works. I know that developers should always look at them, but sometime you don't know where to look at, so the link can have an added value. WDYT ?
Sure, I like the idea. Done in dcf4f59. |
mayurkale22
force-pushed
the
plugin-doc
branch
from
dcf4f59
to
eb84be2
Compare
danielkhan
approved these changes
Sep 27, 2019
lukaswelinder
pushed a commit
to agile-pm/opentelemetry-js
that referenced
this pull request
Jul 24, 2020
Clone `options.tags` before assignment due to unnecessary mutations inside `Tracer` (open-telemetry#345) Signed-off-by: Fedorov Anton <fapspirit@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which problem is this PR solving?