Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(opencensus-shim): add OpenCensus shim package boilerplate #3750

Merged
merged 8 commits into from
Apr 25, 2023

Conversation

aabmass
Copy link
Member

@aabmass aabmass commented Apr 20, 2023

Which problem is this PR solving?

Part of #3749 with more PRs to follow. Next PR draft #3751

Short description of the changes

Adds the boilerplate for opencensus shim package.

Type of change

Please delete options that are not relevant.

  • New feature (non-breaking change which adds functionality)

How Has This Been Tested?

This contains no actual code, but npm lint passes.

Checklist:

  • Followed the style guidelines of this project
  • Unit tests have been added
  • Documentation has been updated
    I'm planning to add a changelog entry in the final PR of the set where this is actually fully implemented.

@codecov
Copy link

codecov bot commented Apr 20, 2023

Codecov Report

Merging #3750 (f783898) into main (cd0d880) will increase coverage by 0.00%.
The diff coverage is n/a.

❗ Current head f783898 differs from pull request most recent head 89af775. Consider uploading reports for the commit 89af775 to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3750   +/-   ##
=======================================
  Coverage   93.43%   93.44%           
=======================================
  Files         290      289    -1     
  Lines        8849     8829   -20     
  Branches     1834     1829    -5     
=======================================
- Hits         8268     8250   -18     
+ Misses        581      579    -2     

see 2 files with indirect coverage changes

@aabmass aabmass marked this pull request as ready for review April 20, 2023 22:14
@aabmass aabmass requested a review from a team as a code owner April 20, 2023 22:14
@aabmass aabmass changed the title feat(opencensus-shim): add initial OpenCensus trace shim implementation feat(opencensus-shim): add OpenCensus shim package boilerplate Apr 20, 2023
Copy link
Member

@pichlermarc pichlermarc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for adding this. 🙂
Looks like this will need a changelog entry, and then this PR should be good to merge 🙂

@aabmass
Copy link
Member Author

aabmass commented Apr 21, 2023

@pichlermarc should I add a changelog entry for each PR in the series or just one entry once it's in a usable releasable state?

Co-authored-by: Marc Pichler <marc.pichler@dynatrace.com>
@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Apr 21, 2023

CLA Signed

The committers listed above are authorized under a signed CLA.

@pichlermarc
Copy link
Member

@pichlermarc should I add a changelog entry for each PR in the series or just one entry once it's in a usable releasable state?

@aabmass I think previously, we've had each PR for a new package have its own changelog entry, even if just adding boilerplate code, so we'd prefer this approach 🙂

@pichlermarc
Copy link
Member

/easycla

@dyladan
Copy link
Member

dyladan commented Apr 24, 2023

@pichlermarc should I add a changelog entry for each PR in the series or just one entry once it's in a usable releasable state?

@aabmass I think previously, we've had each PR for a new package have its own changelog entry, even if just adding boilerplate code, so we'd prefer this approach 🙂

I actually think we should try to make our changelogs more user focused. @pichlermarc is right in the past we've done one per PR but I think having a single changelog entry for the release is friendlier to users.

@pichlermarc
Copy link
Member

@pichlermarc should I add a changelog entry for each PR in the series or just one entry once it's in a usable releasable state?

@aabmass I think previously, we've had each PR for a new package have its own changelog entry, even if just adding boilerplate code, so we'd prefer this approach slightly_smiling_face

I actually think we should try to make our changelogs more user focused. @pichlermarc is right in the past we've done one per PR but I think having a single changelog entry for the release is friendlier to users.

Makes sense. In that case I'll apply the skip-changelog label as we've set the package to private now, then we can add a changelog entry when we set private to false . 🙂

@aabmass
Copy link
Member Author

aabmass commented Apr 24, 2023

The failed window test looks like a flake, can someone re-run the failure? bumped and its passing

@pichlermarc pichlermarc merged commit 6676414 into open-telemetry:main Apr 25, 2023
@aabmass aabmass deleted the oc-shim-1 branch April 25, 2023 13:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants