-
Notifications
You must be signed in to change notification settings - Fork 743
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(opencensus-shim): add OpenCensus shim package boilerplate #3750
Conversation
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #3750 +/- ##
=======================================
Coverage 93.43% 93.44%
=======================================
Files 290 289 -1
Lines 8849 8829 -20
Branches 1834 1829 -5
=======================================
- Hits 8268 8250 -18
+ Misses 581 579 -2 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for adding this. 🙂
Looks like this will need a changelog entry, and then this PR should be good to merge 🙂
experimental/packages/opentelemetry-shim-opencensus/package.json
Outdated
Show resolved
Hide resolved
@pichlermarc should I add a changelog entry for each PR in the series or just one entry once it's in a usable releasable state? |
Co-authored-by: Marc Pichler <marc.pichler@dynatrace.com>
@aabmass I think previously, we've had each PR for a new package have its own changelog entry, even if just adding boilerplate code, so we'd prefer this approach 🙂 |
/easycla |
I actually think we should try to make our changelogs more user focused. @pichlermarc is right in the past we've done one per PR but I think having a single changelog entry for the release is friendlier to users. |
Makes sense. In that case I'll apply the |
|
Which problem is this PR solving?
Part of #3749 with more PRs to follow. Next PR draft #3751
Short description of the changes
Adds the boilerplate for opencensus shim package.
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
This contains no actual code, but
npm lint
passes.Checklist:
I'm planning to add a changelog entry in the final PR of the set where this is actually fully implemented.