Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(opencensus-shim) add mapping logic and propagation shim #3751

Merged
merged 1 commit into from
May 5, 2023

Conversation

aabmass
Copy link
Member

@aabmass aabmass commented Apr 21, 2023

Which problem is this PR solving?

Part of #3749 [PR 2 of 5]

Finished state of this feature: #3778

Short description of the changes

Adds some of the basic mapping logic between OpenCensus <-> OpenTelemetry interfaces. This will be used in the next PR (#3756) which adds the Shim tracer and span implementations. As before, I'll update the changelog in the final PR of the series.

Type of change

Please delete options that are not relevant.

  • New feature (non-breaking change which adds functionality)

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • Added unit tests for all the functionality

Checklist:

  • Followed the style guidelines of this project
  • Unit tests have been added

@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Apr 21, 2023

CLA Signed

The committers listed above are authorized under a signed CLA.

@codecov
Copy link

codecov bot commented Apr 21, 2023

Codecov Report

Merging #3751 (29abd11) into main (32ae641) will increase coverage by 0.00%.
The diff coverage is 93.22%.

❗ Current head 29abd11 differs from pull request most recent head fbe7d47. Consider uploading reports for the commit fbe7d47 to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3751   +/-   ##
=======================================
  Coverage   93.20%   93.20%           
=======================================
  Files         296      298    +2     
  Lines        8998     9057   +59     
  Branches     1853     1864   +11     
=======================================
+ Hits         8387     8442   +55     
- Misses        611      615    +4     
Impacted Files Coverage Δ
...s/opentelemetry-shim-opencensus/src/propagation.ts 80.00% <80.00%> (ø)
...ges/opentelemetry-shim-opencensus/src/transform.ts 100.00% <100.00%> (ø)

@aabmass aabmass changed the title oc shim 2 feat(opencensus-shim) add mapping logic and propagation shim Apr 21, 2023
@aabmass aabmass force-pushed the oc-shim-2 branch 3 times, most recently from ffc22f9 to 794b616 Compare April 25, 2023 13:58
@aabmass aabmass marked this pull request as ready for review April 25, 2023 14:00
@aabmass aabmass requested a review from a team as a code owner April 25, 2023 14:00
@aabmass aabmass force-pushed the oc-shim-2 branch 2 times, most recently from 5c3af65 to 3136f4b Compare May 2, 2023 15:12
Copy link
Member

@pichlermarc pichlermarc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thank you for taking the time to work on this. 🙂

@pichlermarc pichlermarc merged commit 7255da9 into open-telemetry:main May 5, 2023
13 of 14 checks passed
@aabmass aabmass deleted the oc-shim-2 branch May 5, 2023 14:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants