Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gRPC example using proto-loader #385

Merged
merged 4 commits into from
Oct 18, 2019
Merged

gRPC example using proto-loader #385

merged 4 commits into from
Oct 18, 2019

Conversation

mayurkale22
Copy link
Member

Which problem is this PR solving?

  • This is the dynamic code generation variant of the gRPC examples. Code in these examples is generated at runtime using Protobuf.js.

Short description of the changes

@mayurkale22 mayurkale22 changed the title Grpc example v2 gRPC example using proto-loader Oct 1, 2019
@codecov-io
Copy link

codecov-io commented Oct 2, 2019 •
edited
Loading

Codecov Report

Merging #385 into master will increase coverage by 0.08%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master     #385      +/-   ##
==========================================
+ Coverage   95.32%   95.41%   +0.08%     
==========================================
  Files         124      124              
  Lines        6053     6171     +118     
  Branches      509      507       -2     
==========================================
+ Hits         5770     5888     +118     
  Misses        283      283
Impacted Files Coverage Δ
...entelemetry-exporter-jaeger/test/transform.test.ts 100% <0%> (ø) ⬆️
...pe-async-hooks/test/AsyncHooksScopeManager.test.ts 100% <0%> (ø) ⬆️
.../opentelemetry-exporter-jaeger/test/jaeger.test.ts 100% <0%> (ø) ⬆️

markwolff
markwolff approved these changes Oct 4, 2019
View reviewed changes
Copy link
Member

@markwolff markwolff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

examples/grpc_dynamic_codegen/capitalize_client.js Show resolved Hide resolved
@mayurkale22 mayurkale22 mentioned this pull request Oct 18, 2019
Closed
@mayurkale22 mayurkale22 merged commit ee1533a into open-telemetry:master Oct 18, 2019
@mayurkale22 mayurkale22 deleted the grpc_example_v2 branch October 18, 2019 22:31
pichlermarc pushed a commit to dynatrace-oss-contrib/opentelemetry-js that referenced this pull request Dec 15, 2023
@obecny
v0.14.0 proposal (open-telemetry#385)
7a87f41 
* chore: 0.14.0 proposal

* chore: changelog
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@draffensperger draffensperger draffensperger left review comments

@danielkhan danielkhan danielkhan approved these changes

@markwolff markwolff markwolff approved these changes

@bg451 bg451 Awaiting requested review from bg451

@iredelmeier iredelmeier Awaiting requested review from iredelmeier

@OlivierAlbertini OlivierAlbertini Awaiting requested review from OlivierAlbertini

@rochdev rochdev Awaiting requested review from rochdev

@vmarchaud vmarchaud Awaiting requested review from vmarchaud

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@mayurkale22 @codecov-io @danielkhan @draffensperger @markwolff