Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Add otel-api as dev dep for sandbox tests #4020

Merged
merged 2 commits into from
Jul 26, 2023

Conversation

MSNev
Copy link
Contributor

@MSNev MSNev commented Jul 24, 2023

Which problem is this PR solving?

This PR is adding the opentelemetry-api as a dev dependency to the exporter-logs-otlp-http as the tests are directly importing the otel-api and this is breaking when importing into the web-sandbox as the used dependency is not listed.

THe web-sandbox is using rollup for is packaging / bundling which requires all direct used dependencies to be listed

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Tested in a local web-sandbox repo adding the dev dependency and by adding and running all tests in the js repo

@MSNev MSNev requested a review from martinkuba July 24, 2023 16:39
@MSNev MSNev requested a review from a team as a code owner July 24, 2023 16:39
@codecov
Copy link

codecov bot commented Jul 24, 2023

Codecov Report

Merging #4020 (96a0c0b) into main (9f71800) will not change coverage.
The diff coverage is n/a.

❗ Current head 96a0c0b differs from pull request most recent head f1b8ea9. Consider uploading reports for the commit f1b8ea9 to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #4020   +/-   ##
=======================================
  Coverage   92.30%   92.30%           
=======================================
  Files         321      321           
  Lines        9189     9189           
  Branches     1953     1953           
=======================================
  Hits         8482     8482           
  Misses        707      707           

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants