Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: bump typescript version to ^3.7.2 #497

Merged

Conversation

dyladan
Copy link
Member

@dyladan dyladan commented Nov 6, 2019

Which problem is this PR solving?

  • Fix build failures on latest typescript
  • Bump to latest typescript

Short description of the changes

  1. Update typescript version to ^3.7.2 in all package.json files
  2. Remove unreachable code from dns plugin test
  3. Remove always-true if-statement from grpc plugin

REVIEWERS PLEASE PAY PARTICULAR ATTENTION TO POINTS 2 AND 3

@codecov-io
Copy link

codecov-io commented Nov 6, 2019

Codecov Report

Merging #497 into master will decrease coverage by 0.04%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master     #497      +/-   ##
==========================================
- Coverage   94.98%   94.93%   -0.05%     
==========================================
  Files         136      136              
  Lines        6482     6381     -101     
  Branches      567      570       +3     
==========================================
- Hits         6157     6058      -99     
+ Misses        325      323       -2
Impacted Files Coverage Δ
...in-dns/test/integrations/dnspromise-lookup.test.ts 91.58% <ø> (+1.68%) ⬆️
packages/opentelemetry-plugin-grpc/src/grpc.ts 96.23% <100%> (-0.05%) ⬇️
...ages/opentelemetry-plugin-http/test/utils/utils.ts 33.33% <0%> (-26.67%) ⬇️
...es/opentelemetry-node/src/instrumentation/utils.ts 90.47% <0%> (-9.53%) ⬇️
...ges/opentelemetry-tracing/src/NoopSpanProcessor.ts 66.66% <0%> (-8.34%) ⬇️
packages/opentelemetry-tracing/src/config.ts 100% <0%> (ø) ⬆️
packages/opentelemetry-tracing/src/utility.ts 100% <0%> (ø) ⬆️
...entelemetry-exporter-jaeger/test/transform.test.ts 100% <0%> (ø) ⬆️
packages/opentelemetry-tracing/test/Span.test.ts 100% <0%> (ø) ⬆️
packages/opentelemetry-metrics/src/Utils.ts 100% <0%> (ø) ⬆️
... and 12 more

Copy link
Member

@mayurkale22 mayurkale22 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 💯

@mayurkale22 mayurkale22 added the enhancement New feature or request label Nov 6, 2019
@mayurkale22 mayurkale22 merged commit 1f90ce2 into open-telemetry:master Nov 8, 2019
@Flarna Flarna deleted the bump-typescript branch December 13, 2019 20:33
dyladan added a commit to dyladan/opentelemetry-js that referenced this pull request Sep 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants