Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update getting started to tracer registry #709

Conversation

naseemkullah
Copy link
Member

fixes #682

@codecov-io
Copy link

codecov-io commented Jan 19, 2020

Codecov Report

Merging #709 into master will increase coverage by 1.65%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master     #709      +/-   ##
==========================================
+ Coverage   90.92%   92.57%   +1.65%     
==========================================
  Files         220      221       +1     
  Lines       10302    10195     -107     
  Branches      946      926      -20     
==========================================
+ Hits         9367     9438      +71     
+ Misses        935      757     -178
Impacted Files Coverage Δ
packages/opentelemetry-plugin-https/src/https.ts 100% <0%> (ø) ⬆️
...ntelemetry-plugin-https/test/utils/httpsRequest.ts 95.23% <0%> (ø) ⬆️
...ges/opentelemetry-plugin-https/test/utils/utils.ts 60% <0%> (ø) ⬆️
...in-dns/test/integrations/dnspromise-lookup.test.ts 91.58% <0%> (ø) ⬆️
...emetry-plugin-https/test/utils/DummyPropagation.ts 100% <0%> (ø) ⬆️
...n-postgres/opentelemetry-plugin-pg/test/pg.test.ts 94.29% <0%> (ø) ⬆️
...lugin-https/test/functionals/https-disable.test.ts 100% <0%> (ø) ⬆️
.../opentelemetry-exporter-collector/src/transform.ts 88.88% <0%> (-8.09%) ⬇️
...lugin-https/test/integrations/https-enable.test.ts 94.35% <0%> (ø) ⬆️
...ry-plugin-dns/test/functionals/dns-disable.test.ts 100% <0%> (ø) ⬆️
... and 64 more

Copy link
Member

@OlivierAlbertini OlivierAlbertini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe that Registry should be renamed to Provider, can you confirm @dyladan ? Related to #699

@mayurkale22
Copy link
Member

I believe that Registry should be renamed to Provider, can you confirm @dyladan ? Related to #699

I think the decision is not yet made on the name, for now we should continue with Registry and come back to this in the future.

Copy link
Member

@mayurkale22 mayurkale22 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@mayurkale22 mayurkale22 added the document Documentation-related label Jan 20, 2020
@mayurkale22 mayurkale22 merged commit 8b62485 into open-telemetry:master Jan 20, 2020
@naseemkullah naseemkullah deleted the getting-started-tracer-registries branch April 9, 2021 18:18
pichlermarc pushed a commit to dynatrace-oss-contrib/opentelemetry-js that referenced this pull request Dec 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
document Documentation-related
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update getting-started guide based on TracerRegistry
5 participants