-
Notifications
You must be signed in to change notification settings - Fork 794
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: rename registry to provider #699
chore: rename registry to provider #699
Conversation
Codecov Report
@@ Coverage Diff @@
## master #699 +/- ##
==========================================
+ Coverage 89.69% 91.42% +1.72%
==========================================
Files 214 214
Lines 10045 9946 -99
Branches 931 913 -18
==========================================
+ Hits 9010 9093 +83
+ Misses 1035 853 -182
|
Provider is not a good name for languages that support DI. Can you show me in the specs where that is suggested? |
@bogdandrutu the current spec is "Factory" but there is a vocal minority group that doesn't like that. I suggested "Registry" and @yurishkuro didn't like that because you don't actually register tracers with it, it provides tracers. The current suggestion that seems to be acceptable by most people is "Provider" and I am currently using that language in my PRs to the spec. Honestly, I would rather call it Factory since it is a factory pattern. I don't know why such a simple thing can be blocking named tracers for so long. We need to decide on a name so that we can release the next version. We don't want to release with "Registry" just to be told by spec that we need to change to something else. Because we haven't released with named tracers yet, now is a good time to make this change. |
Based on a simple survey of other sigs it looks like one name has no real agreement:
From @yurishkuro: https://github.com/open-telemetry/opentelemetry-specification/pull/408/files#r366501814
Here is the original conversation on otep 76 open-telemetry/oteps#76 (comment) |
Closed in favor of #749 |
Co-authored-by: Amir Blum <amir@aspecto.io> Co-authored-by: Valentin Marchaud <contact@vmarchaud.fr>
Fixes #740
Because of the spec changing the name they use, we need to use the "provider" naming scheme. This is a simple rename and changes no behavior.