Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resource settings behave differently on otel-collector and target-allocator #1914

Closed
cmergenthaler opened this issue Jul 12, 2023 · 2 comments · Fixed by #2040
Closed

Resource settings behave differently on otel-collector and target-allocator #1914

cmergenthaler opened this issue Jul 12, 2023 · 2 comments · Fixed by #2040
Assignees
Labels
area:target-allocator Issues for target-allocator good first issue Good for newcomers

Comments

@cmergenthaler
Copy link
Contributor

cmergenthaler commented Jul 12, 2023

Currently, the resource settings in OpenTelemetryCollector CRD behave differently for otel-collector and target-allocator. For the latter, default values are set if not provided which makes it impossible to i.e. unset cpu limits. On the collector, no default values are set at all, which makes it easy to customize to the pods' needs.

The following example will result in different setups for otel-collector and target-allocator. TA will have a default cpu limit of 200m, collector will have an unset cpu limit.

apiVersion: opentelemetry.io/v1alpha1
kind: OpenTelemetryCollector
metadata:
  name: otel
spec:
  mode: deployment
  resources:
    requests:
      cpu: 150m
      memory: 200Mi
    limits:
      memory: 500Mi
  targetAllocator:
    enabled: true
    resources:
      requests:
        cpu: 150m
        memory: 200Mi
      limits:
        memory: 500Mi
@jaronoff97 jaronoff97 added good first issue Good for newcomers area:target-allocator Issues for target-allocator labels Jul 17, 2023
@yuriolisa
Copy link
Contributor

/assign

@yuriolisa yuriolisa self-assigned this Aug 7, 2023
@Toaddyan
Copy link
Contributor

Toaddyan commented Aug 8, 2023

/assign

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:target-allocator Issues for target-allocator good first issue Good for newcomers
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants