Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

When using OpenTelemetryCollector nodeSelector and later removing it, collector pod doesn't clean up the nodeSelector #2940

Closed
janario opened this issue May 9, 2024 · 0 comments · Fixed by #2941
Labels
bug Something isn't working

Comments

@janario
Copy link
Contributor

janario commented May 9, 2024

Component(s)

collector

What happened?

Description

When adding OpenTelemetryCollector.spec.nodeSelector and later removing it, it doesn't get applied to the collector Pods.

Steps to Reproduce

Scenario,

  1. create an OpenTelemetryCollector with spec.nodeSelector
    a. it will create pods(from DaemonSet/Deployment/Statefulset) with the nodeSelector ✅
  2. change OpenTelemetryCollector to remove nodeSelector
    a. it is not removed from pods(from DaemonSet/Deployment/Statefulset)
  3. change OpenTelemetryCollector to add another nodeSelector (different key/value from step 1)
    a. it is adding another nodeSelector to the pod and keeping both (step 1 and step 3)

Expected Result

Collector Pods should reflect exactly the OpenTelemetryCollector.spec.nodeSelector

Actual Result

Collector Pods get nodeSelectors but never removed to reflect the OpenTelemetryCollector.spec.nodeSelector.

Kubernetes Version

1.26

Operator version

0.98.0

Collector version

0.98.0

Environment information

Environment

OS: (e.g., "Ubuntu 20.04")
Compiler(if manually compiled): (e.g., "go 14.2")

Log output

No response

Additional context

No response

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants