Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for golang auto-instrumentation #908

Closed
pavolloffay opened this issue Jun 3, 2022 · 7 comments · Fixed by #1555
Closed

Add support for golang auto-instrumentation #908

pavolloffay opened this issue Jun 3, 2022 · 7 comments · Fixed by #1555
Labels
area:auto-instrumentation Issues for auto-instrumentation

Comments

@pavolloffay
Copy link
Member

pavolloffay commented Jun 3, 2022

The https://github.com/keyval-dev/opentelemetry-go-instrumentation could be used for golang auto-instrumentation.

From the object management perspective it would be better if the project was part of the CNCF/OTEL community.

cc) @edeNFed

@pavolloffay pavolloffay added the area:auto-instrumentation Issues for auto-instrumentation label Jun 3, 2022
@pavolloffay
Copy link
Member Author

Golang auto-instrumentation has been donated open-telemetry/opentelemetry-go-instrumentation#2

@TylerHelmuth
Copy link
Member

@pavolloffay @open-telemetry/operator-maintainers @open-telemetry/operator-approvers if the community is willing, I would like to start working on this.

@edeNFed
Copy link

edeNFed commented Feb 22, 2023

@TylerHelmuth I'll be happy to help if needed

@TylerHelmuth
Copy link
Member

@edeNFed sounds good! I'm sure I'll have some questions once I get started.

@TylerHelmuth
Copy link
Member

Please assign this to me.

@TylerHelmuth
Copy link
Member

Question: will we want to build our own version of the go auto-instrumentation agent like we do for the other languages or will it be acceptable to use the image published by opentelemetry-go-instrumentation?

@TylerHelmuth
Copy link
Member

As discussed in the SIG meeting today, we'll move forward with using an image published from open-telemetry/opentelemetry-go-instrumentation instead of building our own. This decision is made based on the increased complexity of the go auto instrumentation due to eBPF and the necessary offsets json file we would have to manage if we had our own image.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:auto-instrumentation Issues for auto-instrumentation
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants