-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[zh] Add zh version of homepage #4341
Conversation
64fe09d
to
4df3b11
Compare
Thank you @windsonsea! We will take your PR to work towards making the Chinese version available, so we will push commits to your PR, so if you want to apply any additional changes make sure you pull commits if there are any
This is good to know, thanks. As a starting point we can disable prettier for the
Yes! The moment we have the first language landed, we can work on that. |
Seems this issue is talking about Chinese prettier: prettier/prettier#14936 We need to add some rules:
|
FYI, I'll get working on this as soon as I can. |
19436ed
to
4662ccb
Compare
@windsonsea - could you please only include the translation of the homepage? We'll get to the other page later, but at the moment, it is just causing more trouble than is worth (because there isn't an index page for that section yet). |
Hi @chalin , sure, only the _index.md is included now. |
@windsonsea - is "OpenTelemetry 项目网站" a good translation of "The OpenTelemetry Project Site", and if not, what would be? |
Yes, it's fine. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@windsonsea PTAL at my inline comments
@windsonsea - I'm going to merge the suggested edits now because I want to merge this PR. We can always fix it in a followup PR. |
In case you missed it in the opening-comment edit I made, you can see a preview of the Chinese homepage: |
Cool! The preview looks good. 👍 |
Some tips:
/zh
to its relevant url path if the Chinese version of the page is available.zh/docs/
npx prettier --w
is not so perfect to Chinese. It's not correct to add any space between Chinese words. It's recommended to add a space after en words, numbers, and punctuationsEdit (@chalin)
Preview: https://deploy-preview-4341--opentelemetry.netlify.app/zh/
Redirect tests: