Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RPC message namespace is too generic #658

Closed
lmolkova opened this issue Apr 27, 2023 · 1 comment · Fixed by #854
Closed

RPC message namespace is too generic #658

lmolkova opened this issue Apr 27, 2023 · 1 comment · Fixed by #854

Comments

@lmolkova
Copy link
Contributor

lmolkova commented Apr 27, 2023

Names of RPC message attributes (message.id, message.compressed_size, etc) are too generic, while their semantics are very narrow.

https://github.com/open-telemetry/opentelemetry-specification/blob/b5c6a6dc48752a3ea740f08bed0c2975bae19673/semantic_conventions/trace/rpc.yaml#L193

We also have messaging.message.* namespace which contains messaging-specific attributes with quite similar names, but different semantics.

Assuming we create a registry of attributes and suggest reusing them across signals, we should either have a general-purpose message namespace, or, preferably, put RPC messages under rpc.message.*.

@Oberon00
Copy link
Member

I think this is a legacy holdover from OpenCensus grpc streaming support

@arminru arminru transferred this issue from open-telemetry/opentelemetry-specification Jan 19, 2024
@pyohannes pyohannes moved this from V1 - Stable Semantics to In Triage in Spec: Messaging Semantics Jan 19, 2024
@pyohannes pyohannes moved this from In Triage to V1 - Stable Semantics in Spec: Messaging Semantics Feb 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: V1 - Stable Semantics
Development

Successfully merging a pull request may close this issue.

5 participants