Fixes Disbursement Date field #3135
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@muskankhedia welcome to community |
|
Thank You Sir.
…On Sun, Nov 24, 2019 at 9:23 AM Nayan Ambali ***@***.***> wrote:
@muskankhedia <https://github.com/muskankhedia> welcome to community
cc: @santoshconflux <https://github.com/santoshconflux> @edcable
<https://github.com/edcable>
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#3135?email_source=notifications&email_token=AI2EKIZSQDY7TMEMWU4WUZLQVH3B7A5CNFSM4JQZQE6KYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEFADEKI#issuecomment-557855273>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AI2EKI7GB7BAHM2AMVYMZRTQVH3B7ANCNFSM4JQZQE6A>
.
--
Thank You
Muskan Khedia
|
|
@muskankhedia , Thank you. I will test it soon. By the way, PR title says "Fixes Disbursement Date field". Does it address only 'disbursement date' field or also other fields mentioned in the #2972 ? |
|
@santoshconflux Presently it fixes only 'disbursement date' field only. I will be soon fixing the bug at other webpages and will create a new PR. |
edcable
added this to PR Changes Requested/Ready For PR Review
in Fineract 1.4/Mifos 19.12 Fixes
via automation
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes the date-picker in the different categories.
Related issues and discussion
#2972
Screenshots, if any
Checklist
Please make sure these boxes are checked before submitting your pull request - thanks!
Validate the JS and HTML files with
grunt validateto detect errors and potential problems in JavaScript code.Run the tests by opening
test/SpecRunner.htmlin the browser to make sure you didn't break anything.If you have multiple commits please combine them into one commit by squashing them.
Read and understood the contribution guidelines at
community-app/Contributing.md.