This repository has been archived by the owner on Feb 19, 2019. It is now read-only.
MifosX-855: Capture meeting time and location during meeting creation #831
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@ashokuvce, can you review this code? |
| @@ -148,7 +175,7 @@ public static CalendarData sensibleDefaultsForNewCalendarCreation() { | |||
| final Long lastUpdatedByUserId = null; | |||
| final String lastUpdatedByUsername = null; | |||
|
|
|||
| return new CalendarData(id, calendarInstanceId, entityId, entityType, title, description, location, startDate, endDate, duration, | |||
| return new CalendarData(id, calendarInstanceId, entityId, entityType, title, description, location, startDate, endDate, new Integer(0), duration, | |||
There was a problem hiding this comment.
Use Local variable start time created on top instead of new Integer(0)
There was a problem hiding this comment.
Sorry. It's a mistake. Fixed it.
thanks.
|
@vishwasbabu are we ditching this PR?. We need this functionality for Jananidhi. let me know, I will send another PR. |
|
@Nayan Sorry missed your message! We will bring in this PR with a few minor changes immediately after this release. I'll keep you posted |
|
closing off this PR, we would want to use a datetime field for storing the meeting start time, similar to https://developers.google.com/google-apps/calendar/concepts#timed_events |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated the MifosX and the community-app to capture meeting time(start time+duration) and location.
JIRA reference issue: https://mifosforge.jira.com/browse/MIFOSX-855