Add implementation of linear global translation (LiGT) - Global translations from global rotations and track observations #2065
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
VINF-SJTU
VINF-SJTU group
VINF-SJTU group
VINF-SJTU group
VINF-SJTU group
VINF-SJTU group
VINF-SJTU group
VINF-SJTU group
VINF-SJTU group
VINF-SJTU group
Propose to update LTL and A-lr matrices locally in order to traverse tracks in parallel.
…ix_update Parallelism improvment - local update of LTL and A-LR matrices
… features - Minor cleanup for TRANSLATION_LIGT (always defined, but code working only if USE_PATENTED_LIGT is active)
Minor cleanup
reason: LiGT has been embedded in the openslam_multiview library.
reason: LiGT has been embedded in openmvg_multiview library.
- Remove main_LiGT_algorithm and LiGT file related functions - Now LiGT::Solution return true of false depending of solver failure or success - Remove unused functions - Attitudes -> Rotations - Fix slow behavior to update tracks (using parallelism was a bad idea) - better pre-allocate memory
…velop Conflicts: src/openMVG/multiview/LiGT/LiGT_algorithm_converter.cpp src/software/SfM/CMakeLists.txt
- move the definition of MIN_TRACKING_LENGTH from 'LiGT_algorithm.cpp' to 'LiGT_algorithm_converter.cpp' and use filter of TracksBuilder to do this work.
reset the MIN_TRACKING_LENGTH to be 2
|
This pull request introduces 1 alert when merging 9041f33 into 1f54383 - view on LGTM.com new alerts:
|
|
Seems like there is an issue with Spectra on mac https://github.com/pose-only-vision/openMVG/runs/6442451077?check_suite_focus=true#step:6:302 |
|
This pull request introduces 1 alert when merging 9b51bea into 0842de9 - view on LGTM.com new alerts:
|
|
Closing this PR, will re-open when we will have an understanding of the failure on Mac |
- Avoid use auto on Eigen expression - Fix a typo
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's new
Implementation of LiGT from [1]. An alternative to Translation_Structure_L1_ConstraintBuilder that does not compute the 3D coordinates of the points.
This implementation is supported by the Inertial and Visual Fusion (VINF) research group at Shanghai Jiao Tong University https://www.researchgate.net/lab/Inertial-visual-Fusion-VINF-Yuanxin-Wu
How to use it?
openMVG_main_SfM --translationAveraging 4[1] A Pose-only Solution to Visual Reconstruction and Navigation
Qi Cai, Lilian Zhang, Yuanxin Wu, Wenxian Yu, Dewen Hu
Details: