New device and boot selection dialogs #1106

dgdavid · 2024-03-19T15:04:42Z

This PR implements the new UI selectors for the target installation device and for the boot device, see https://github.com/openSUSE/agama/blob/master/doc/storage_ui.md.

For the installation device it offers the following options:

Select a target disk (the file systems are created over new partitions).
Create a new LVM volume group (the file systems are crated over logical volumes).
The option for reusing LVM volume groups is not offered yet.

For the boot device it offers the following options:

To use the selected disk for installation.
To use a different disk.
To not configure boot partitions.

Screenshots

Toggle

coveralls · 2024-03-25T15:14:28Z

coverage: 75.12% (+0.03%) from 75.095%
when pulling 5e9c002 on storage-next-selector
into 7e1476c on storage-next-device-selection.

dgdavid · 2024-03-25T19:21:59Z

web/src/components/core/ExpandableSelector.jsx

+ * @param {string[]} [props.initialExpandedKeys=[]] - Ids of initially expanded items.
+ * @param {(selection: Array<object>) => void} [props.onSelectionChange=noop] - Callback to be triggered when selection changes.
+ * @param {object} [props.tableProps] - Props for {@link https://www.patternfly.org/components/table/#table PF/Table}.
+ */


// TODO:

Add a note why this cannot be build with core/TreeTable.

Try to unify them as much as possible (after current milestone)

dgdavid · 2024-03-27T17:29:14Z

web/src/components/storage/BootSelectionDialog.jsx

+            {_("Additional partitions to boot the system will be configured at /dev/vdc, \
+            the device selected for installing the system.")}


Actually, the idea here is to go for a %s and then replace it by the selected installationDevice

Suggested change

{_("Additional partitions to boot the system will be configured at /dev/vdc, \

the device selected for installing the system.")}

{_("Additional partitions to boot the system will be configured in \

the device selected for installing the system, currently %s")}

But I'm not sure how to make it work. I mean, when target is disk is pretty clear, just to put the device.name or deviceLabel there. But what is the right value when the target is a new LVM thing (see https://github.com/openSUSE/agama/pull/1106/files#diff-bd6c15ca365f9adcb6bb3d76300f7729cfbd21274b895e1504c5956443e8a99cR53-R61)

Let's talk about it on Monday.

dgdavid · 2024-03-27T17:30:34Z

web/src/components/overview/StorageSection.jsx

+
+      return (
+        <Text>
+          <span dangerouslySetInnerHTML={{ __html: msg1 }} />


NOTE for my self: I feel we're abusing of this technique. Try to looks for a better, different, or safer approach (if any).

ancorgs

Content-wise it LGTM, but I guess we need to squash those 49 WIP commits(!) into something more reasonable.

Co-authored-by: Ancor Gonzalez Sosa <ancorgs@gmail.com>

Co-authored-by: David Díaz González <dgonzalez@suse.de>

Co-authored-by: Ancor Gonzalez Sosa <ancorgs@gmail.com> Co-authored-by: David Díaz González <dgonzalez@suse.de>

Co-authored-by: Ancor Gonzalez Sosa <ancorgs@gmail.com>

ancorgs

I have not re-checked everything, but the list of commits looks reasonable now.

So LGTM.

Merging feature branch which includes: * #1068 * #1106

Prepare for releasing Agama 8. It includes the following pull requests: * #884 * #886 * #914 * #918 * #956 * #957 * #958 * #959 * #960 * #961 * #962 * #963 * #964 * #965 * #966 * #969 * #970 * #976 * #977 * #978 * #979 * #980 * #981 * #983 * #984 * #985 * #986 * #988 * #991 * #992 * #995 * #996 * #997 * #999 * #1003 * #1004 * #1006 * #1007 * #1008 * #1009 * #1010 * #1011 * #1012 * #1014 * #1015 * #1016 * #1017 * #1020 * #1022 * #1023 * #1024 * #1025 * #1027 * #1028 * #1029 * #1030 * #1031 * #1032 * #1033 * #1034 * #1035 * #1036 * #1038 * #1039 * #1041 * #1042 * #1043 * #1045 * #1046 * #1047 * #1048 * #1052 * #1054 * #1056 * #1057 * #1060 * #1061 * #1062 * #1063 * #1064 * #1066 * #1067 * #1068 * #1069 * #1071 * #1072 * #1073 * #1074 * #1075 * #1079 * #1080 * #1081 * #1082 * #1085 * #1086 * #1087 * #1088 * #1089 * #1090 * #1091 * #1092 * #1093 * #1094 * #1095 * #1096 * #1097 * #1098 * #1099 * #1100 * #1102 * #1103 * #1104 * #1105 * #1106 * #1109 * #1110 * #1111 * #1112 * #1114 * #1116 * #1117 * #1118 * #1119 * #1120 * #1121 * #1122 * #1123 * #1125 * #1126 * #1127 * #1128 * #1129 * #1130 * #1131 * #1132 * #1133 * #1134 * #1135 * #1136 * #1138 * #1139 * #1140 * #1141 * #1142 * #1143 * #1144 * #1145 * #1146 * #1147 * #1148 * #1149 * #1151 * #1152 * #1153 * #1154 * #1155 * #1156 * #1157 * #1158 * #1160 * #1161 * #1162 * #1163 * #1164 * #1165 * #1166 * #1167 * #1168 * #1169 * #1170 * #1171 * #1172 * #1173 * #1174 * #1175 * #1177 * #1178 * #1180 * #1181 * #1182 * #1183 * #1184 * #1185 * #1187 * #1188 * #1189 * #1190 * #1191 * #1192 * #1193 * #1194 * #1195 * #1196 * #1198 * #1199 * #1200 * #1201 * #1203 * #1204 * #1205 * #1206 * #1207 * #1208 * #1209 * #1210 * #1211 * #1212 * #1213 * #1214 * #1215 * #1216 * #1217 * #1219 * #1220 * #1221 * #1222 * #1223 * #1224 * #1225 * #1226 * #1227 * #1229

dgdavid force-pushed the storage-next-selector branch 2 times, most recently from b1ae067 to f70d44a Compare March 19, 2024 17:45

joseivanlopez mentioned this pull request Mar 25, 2024

New storage settings for different target devices #1068

Merged

joseivanlopez force-pushed the storage-next-selector branch from fc54b1e to 1dc4704 Compare March 25, 2024 15:10

dgdavid force-pushed the storage-next-selector branch from 1dc4704 to fc54b1e Compare March 25, 2024 15:32

joseivanlopez force-pushed the storage-next-selector branch from fc54b1e to bb3e820 Compare March 25, 2024 15:37

ancorgs mentioned this pull request Mar 25, 2024

Alternative to another PR #1115

Closed

dgdavid commented Mar 25, 2024

View reviewed changes

This comment was marked as resolved.

Sign in to view

dgdavid commented Mar 27, 2024

View reviewed changes

ancorgs force-pushed the storage-next-selector branch from 4a7a434 to 4b3a142 Compare April 1, 2024 14:22

joseivanlopez marked this pull request as ready for review April 3, 2024 12:01

joseivanlopez changed the title ~~[WIP]: web: Change the storage device selection dialog~~ New device and boot selection dialogs Apr 3, 2024

ancorgs approved these changes Apr 3, 2024

View reviewed changes

joseivanlopez and others added 12 commits April 3, 2024 14:48

service: Improvements in Drive D-Bus interface

6f0f868

Co-authored-by: Ancor Gonzalez Sosa <ancorgs@gmail.com>

service: Fix settings conversion to Y2Storage

ee52cac

service: Add default boot device to D-Bus

7c46e86

service: Update Gemfile.lock

c59f80c

web: Adapt storage client to changes in D-Bus

1e5ae20

web: Add more device utils

a3067c5

Co-authored-by: Ancor Gonzalez Sosa <ancorgs@gmail.com>

web: Use FilesystemLabel util

38cee8d

Co-authored-by: Ancor Gonzalez Sosa <ancorgs@gmail.com>

web: Small fix in text

53ef918

Co-authored-by: Ancor Gonzalez Sosa <ancorgs@gmail.com>

web: Add ExpandableSelector component

f763cd4

Co-authored-by: David Díaz González <dgonzalez@suse.de>

web: Add DeviceSelectorTable and DevicesFormSelect

52ba9de

Co-authored-by: David Díaz González <dgonzalez@suse.de>

web: Add ControlledPanels

0a0fc82

Co-authored-by: David Díaz González <dgonzalez@suse.de>

web: Add new device selector

dea8654

Co-authored-by: Ancor Gonzalez Sosa <ancorgs@gmail.com> Co-authored-by: David Díaz González <dgonzalez@suse.de>

joseivanlopez and others added 2 commits April 3, 2024 15:33

web: Add boot device selector

1d87d66

Co-authored-by: Ancor Gonzalez Sosa <ancorgs@gmail.com> Co-authored-by: David Díaz González <dgonzalez@suse.de>

web: Improve storage summary

5e9c002

Co-authored-by: Ancor Gonzalez Sosa <ancorgs@gmail.com>

joseivanlopez force-pushed the storage-next-selector branch from 22ef9f0 to 5e9c002 Compare April 3, 2024 14:35

ancorgs approved these changes Apr 3, 2024

View reviewed changes

joseivanlopez merged commit 55ff0ba into storage-next-device-selection Apr 3, 2024
8 checks passed

joseivanlopez deleted the storage-next-selector branch April 3, 2024 15:07

joseivanlopez mentioned this pull request Apr 3, 2024

feature: Device and boot selection #1127

Merged

joseivanlopez added a commit that referenced this pull request Apr 4, 2024

feature: Device and boot selection (#1127)

6291da5

Merging feature branch which includes: * #1068 * #1106

imobachgs mentioned this pull request May 17, 2024

Update to release 8 #1232

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

New device and boot selection dialogs #1106

New device and boot selection dialogs #1106

dgdavid commented Mar 19, 2024 •

edited by joseivanlopez

coveralls commented Mar 25, 2024 •

edited

dgdavid Mar 25, 2024 •

edited

This comment was marked as resolved.

This comment was marked as resolved.

This comment was marked as resolved.

dgdavid Mar 27, 2024

dgdavid Mar 27, 2024

ancorgs left a comment

ancorgs left a comment

		{_("Additional partitions to boot the system will be configured at /dev/vdc, \
		the device selected for installing the system.")}

New device and boot selection dialogs #1106

New device and boot selection dialogs #1106

Conversation

dgdavid commented Mar 19, 2024 • edited by joseivanlopez

Screenshots

coveralls commented Mar 25, 2024 • edited

dgdavid Mar 25, 2024 • edited

Choose a reason for hiding this comment

This comment was marked as resolved.

This comment was marked as resolved.

This comment was marked as resolved.

dgdavid Mar 27, 2024

Choose a reason for hiding this comment

dgdavid Mar 27, 2024

Choose a reason for hiding this comment

ancorgs left a comment

Choose a reason for hiding this comment

ancorgs left a comment

Choose a reason for hiding this comment

dgdavid commented Mar 19, 2024 •

edited by joseivanlopez

coveralls commented Mar 25, 2024 •

edited

dgdavid Mar 25, 2024 •

edited