Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GitHub Action: bind mount /usr/bin/gh into the containers #1162

Merged
merged 1 commit into from
Apr 23, 2024
Merged

GitHub Action: bind mount /usr/bin/gh into the containers #1162

merged 1 commit into from
Apr 23, 2024

Conversation

lslezak
Copy link
Member

@lslezak lslezak commented Apr 23, 2024 •
edited

Problem

  • GitHub action which merges the translations from Weblate failed (Action log)
  • The problem is that the repository changed the GPG signature and the gh package cannot be installed

Solution

  • Do not install it, it already is pre-installed in the default Ubuntu host system
  • The gh tool is a statically linked binary without any dependencies so we can simply just bind mount it from the host into the container
  • We already use this solution in the .github/workflows/weblate-merge-service-po.yml file, let's use it everywhere

@lslezak
GitHub Action: bind mount /usr/bin/gh into the containers
f04d0e4 
We use the `gh` GitHub command line tool to create pull requests.
The tool is installed inside the Tumbleweed container using `zypper`
as usually.

The problem is that the installation might fail in some cases
(GPG key problem, network error,...) and this fails whole action.

But we actually do not need to install the tool, it already is pre-installed in
the default Ubuntu host system. And because the `gh` tool is a statically
linked binary without any dependencies we can simply just bind mount it from
the host inside the container without any installation.
mvidner
mvidner approved these changes Apr 23, 2024
View reviewed changes
Copy link
Member

@mvidner mvidner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for the explanation

@lslezak lslezak merged commit 988ad65 into master Apr 23, 2024
@lslezak lslezak deleted the gh_bind_mount branch April 23, 2024 08:49
@imobachgs imobachgs mentioned this pull request May 17, 2024
Merged
imobachgs added a commit that referenced this pull request May 17, 2024
@imobachgs
Update to release 8 (#1232)
b13e7b7 
Prepare for releasing Agama 8. It includes the following pull requests:

* #884
* #886
* #914
* #918
* #956
* #957
* #958
* #959
* #960
* #961
* #962
* #963
* #964
* #965
* #966
* #969
* #970
* #976
* #977
* #978
* #979
* #980
* #981
* #983
* #984
* #985
* #986
* #988
* #991
* #992
* #995
* #996
* #997
* #999
* #1003
* #1004
* #1006
* #1007
* #1008
* #1009
* #1010
* #1011
* #1012
* #1014
* #1015
* #1016
* #1017
* #1020
* #1022
* #1023
* #1024
* #1025
* #1027
* #1028
* #1029
* #1030
* #1031
* #1032
* #1033
* #1034
* #1035
* #1036
* #1038
* #1039
* #1041
* #1042
* #1043
* #1045
* #1046
* #1047
* #1048
* #1052
* #1054
* #1056
* #1057
* #1060
* #1061
* #1062
* #1063
* #1064
* #1066
* #1067
* #1068
* #1069
* #1071
* #1072
* #1073
* #1074
* #1075
* #1079
* #1080
* #1081
* #1082
* #1085
* #1086
* #1087
* #1088
* #1089
* #1090
* #1091
* #1092
* #1093
* #1094
* #1095
* #1096
* #1097
* #1098
* #1099
* #1100
* #1102
* #1103
* #1104
* #1105
* #1106
* #1109
* #1110
* #1111
* #1112
* #1114
* #1116
* #1117
* #1118
* #1119
* #1120
* #1121
* #1122
* #1123
* #1125
* #1126
* #1127
* #1128
* #1129
* #1130
* #1131
* #1132
* #1133
* #1134
* #1135
* #1136
* #1138
* #1139
* #1140
* #1141
* #1142
* #1143
* #1144
* #1145
* #1146
* #1147
* #1148
* #1149
* #1151
* #1152
* #1153
* #1154
* #1155
* #1156
* #1157
* #1158
* #1160
* #1161
* #1162
* #1163
* #1164
* #1165
* #1166
* #1167
* #1168
* #1169
* #1170
* #1171
* #1172
* #1173
* #1174
* #1175
* #1177
* #1178
* #1180
* #1181
* #1182
* #1183
* #1184
* #1185
* #1187
* #1188
* #1189
* #1190
* #1191
* #1192
* #1193
* #1194
* #1195
* #1196
* #1198
* #1199
* #1200
* #1201
* #1203
* #1204
* #1205
* #1206
* #1207
* #1208
* #1209
* #1210
* #1211
* #1212
* #1213
* #1214
* #1215
* #1216
* #1217
* #1219
* #1220
* #1221
* #1222
* #1223
* #1224
* #1225
* #1226
* #1227
* #1229
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mvidner mvidner mvidner approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@lslezak @mvidner