-
Notifications
You must be signed in to change notification settings - Fork 45
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rebased the portus image to include puma #47
Merged
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1 @@ | ||
README.md |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,26 @@ | ||
FROM opensuse/amd64:42.2 | ||
MAINTAINER SUSE Containers Team <containers@suse.com> | ||
|
||
# Install some helper scripts: | ||
# 1. init: contains the entrypoint of this image. | ||
# 2. check_db.rb: a rails runner used by the `init` script that checks | ||
# if the database is up and running. | ||
# 3. rpm-import-repo-key: temporary script that makes it easier to download | ||
# and import gpg keys from trusted key servers. This is used later on to | ||
# import the OBS key used to sign all the contents of the | ||
# Virtualization:containers project. | ||
COPY init check_db.rb rpm-import-repo-key / | ||
|
||
# Install Portus and prepare the /certificates directory. | ||
RUN /rpm-import-repo-key 55A0B34D49501BB7CA474F5AA193FBB572174FC2 && \ | ||
zypper ar -f obs://Virtualization:containers:Portus/openSUSE_Leap_42.2 portus && \ | ||
zypper ref && \ | ||
zypper -n in portus && \ | ||
zypper -n rm kbd-legacy && \ | ||
zypper clean -a && \ | ||
rm /rpm-import-repo-key && \ | ||
rm -rf /etc/pki/trust/anchors && \ | ||
ln -sf /certificates /etc/pki/trust/anchors | ||
|
||
EXPOSE 3000 | ||
ENTRYPOINT ["/init"] |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
File renamed without changes.
This file was deleted.
Oops, something went wrong.
This file was deleted.
Oops, something went wrong.
This file was deleted.
Oops, something went wrong.
This file was deleted.
Oops, something went wrong.
This file was deleted.
Oops, something went wrong.
This file was deleted.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
File renamed without changes.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are these default values enough to handle the case of Portus authenticating against itself (eg: the crono job scanning the contents of the registry). I remember some issues in the past caused by portus being stuck processing only one request at a time.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes for two reasons:
PORTUS_PUMA_WORKERS
andPORTUS_PUMA_MAX_THREADS
should avoid any blocking issues.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
My question is: wouldn't it be better to provide sane defaults for these environment variables to avoid our users to do the fine tuning?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Note that these defaults come from Portus' side actually 😃 I'll update that there