Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow othername & lineage #83

Open
ghost opened this issue May 22, 2020 · 6 comments · May be fixed by #91
Open

Allow othername & lineage #83

ghost opened this issue May 22, 2020 · 6 comments · May be fixed by #91
Labels
enhancement New feature or request geekodoc 2️⃣ For GeekoDoc version2 only

Comments

@ghost
Copy link

ghost commented May 22, 2020

Within <personname/>s, currently only <firstname/> & <surname/> are allowed. However, a bunch of people legitimately do have middle names or Jr./Sr. added to their name. Hence, <othername/> and <lineage/> should probably be allowed. (AsciiDoctor also tends to generate those tags.)

Should I ever have argued for the opposite, please ignore my past opinions. :)

@tomschr tomschr added the geekodoc Version independent general GeekoDoc issues label Aug 3, 2020
@tomschr tomschr added the geekodoc 2️⃣ For GeekoDoc version2 only label Aug 26, 2021
@ghost
Copy link
Author

ghost commented Aug 27, 2021

Toms yesterday made me aware that DocBook also supports the <givenname/> element. I think we should try to remove <firstname/> in favor of <givenname/>, since the latter is globally more applicable than the Western-centric <firstname/> element.

@tomschr tomschr added the enhancement New feature or request label Sep 3, 2021
@tomschr
Copy link
Contributor

tomschr commented Sep 3, 2021

Removing <firstname> will cause validation problems. I would like to avoid these. Therefor I try to keep it for the time being and add <givenname>, <lineage>, and <honorific> to GeekoDoc.

tomschr added a commit that referenced this issue Sep 3, 2021
In regards to personname:

* Allow othername, honorifc, linage
* Restore content model of personname to not
  mix firstname with givenname
@tomschr tomschr linked a pull request Sep 3, 2021 that will close this issue
tomschr added a commit that referenced this issue Sep 3, 2021
In regards to personname:

* Allow othername, honorifc, linage
* Restore content model of personname to not
  mix firstname with givenname
@ghost
Copy link
Author

ghost commented Sep 3, 2021

If we still operate under the assumption that people have GeekoDoc v1 and v2 installed side by side, I think this might be a compatibility break worth making -- people would explicitly update to the new schema and it would be expected that there may be a few minor issues like this. No?

@tomschr
Copy link
Contributor

tomschr commented Sep 3, 2021

Good point. In that sense, a major release could introduce a compatibility break. The question is if it's worth.

After I've looked into the doc-sle repo, it isn't not that much: I've counted 16 files which contains firstname. So it seems manageable...

Let me think about it.

tomschr added a commit that referenced this issue Sep 6, 2021
In regards to personname:

* Allow givenname, othername, honorifc, and linage
* Restore content model of personname to not
  mix firstname with givenname
@ghost
Copy link
Author

ghost commented Sep 6, 2021

The major repo where the tag is relevant is going to be the SBP repo, I guess. But that largely uses plain DocBook because the documents there are incompatible for a number of reasons.

@tomschr tomschr removed the geekodoc Version independent general GeekoDoc issues label Oct 27, 2021
@tomschr
Copy link
Contributor

tomschr commented Dec 8, 2022

Effort is probably low, could add the other tags.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request geekodoc 2️⃣ For GeekoDoc version2 only
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant