Do not return != 0 unless there are errors.

[juliogonzalez]

After #47 there seems to be a problem.

When there are no PRs we are now returning 0, which is correct since there were no errors.

However Jenkins does the following:

• If gitarro returned 0, it changes it to 1, so downstream job is not launched.
• If gitarro returned 1, it changes it to 0, so downstream job is launched.

We ned to change this behaviour. A Jenkins job must only fail when there is a problem, and not having PRs with changes is not a failure.

What I propose here is to keeping retur 0 when there are no PRs, and modify the output to include a text that we can easily identify with Jenkins.

Right now the text is:
There are no Pull Requests opened or with changes newer than 3600 seconds

Let's change it to:

[NOPRS] There are no Pull Requests opened or with changes newer than 3600 seconds

When --changed_since >= 0

And

[NOPRS] There are no Pull Requests opened

When --change_since < 0 (in fact this is small bug, since it didn't crashed but showed "or with changes newer than -1 seconds")

So we can easily grep if return code is 0 and determine if there were PRs or not without breaking the jobs (in fact we should configure them to send email when they REALLY break, for example because gitarro is not working -a bug, permission problems, etc...).

In the meantime I will remove --changed_since from the log.

With the refactor we should also check if we are doing this at other places.

[MalloZup]

Ok for me, i would only vote instead for the text, a bool variable. ( that jenkins can grep).
If we want to move away from jenkins, we need some general behaviour.

Indeed this behaviour was introduced the time we use the -C option, for running downstram jobs.
This complicate a bit the stuff/behaviour of gitarro.

I think we should add some spec_tests for catching this, meaning:

• add test for ```-changed-since`` with the -C option, and see if we return the bool var.

We have also to consider the 2 way to run gitarro : scheduler -C and runner.

When we execute as Runner, imho is totally ok to have a Red Ball (-1) when a test fail. For unexpected errors there is the yellow ball in jenkins.

The only stuff is that the additional variable, wiil add a extra=dependencie to how the jenkins jobs are configured. ( grepping for a variable)

[juliogonzalez]

Sounds great for me as well.

Do you mean something like:

[PRS=FALSE] There are no Pull Requests opened

?

[MalloZup]

fixed by #77.

[juliogonzalez]

Reopening.

We are still returning != 0 at some other places such as lib/gitarro/backend.rb line 147

[MalloZup]

right :)

[MalloZup]

there is only 1 in backend which is correct to have it there we can close this

[MalloZup]

closubg feel free to reopen, but the only 1 place is not enough :) thx
The place there is right for exiting 1 after test fail