Bring back printing progress per package when initializing build root #200
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ing." This reverts commit e2a3a26. That commit crippled progress reporting. Issue 1: It made the "keeping" messages go away, but the progress indicator would still be printed, so the commit only did half of the intent. Issue 2: Since no newline was emitted (this was part of the "keeping" message) and because stdout is line-buffered, the progress report would only be sporadically emitted. Furthermore, initializating a Debian root is slow compared to RPM, and so there is a long time before any output is shown. Show me my progress as it happens. Reinstate messages about kept packages.
|
@lnussel can you comment on this please? |
|
sorry, I missed the notification. I guess I didn't like the excessive output back then. Nowadays I don't care. |
adrianschroeter
added a commit
that referenced
this pull request
Nov 26, 2015
Bring back printing progress per package when initializing build root
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(This is a repost of the one unmerged commit from pull request #194 so it does not get lost.)
This reverts commit e2a3a26.
That commit crippled progress reporting. Issue 1: It made the
"keeping" messages go away, but the progress indicator would still be
printed, so the commit only did half of the intent.
Issue 2: Since no newline was emitted (this was part of the "keeping"
message) and because stdout is line-buffered, the progress report
would only be sporadically emitted.
Furthermore, initializating a Debian root is slow compared to RPM, and
so there is a long time before any output is shown.
Show me my progress as it happens. Reinstate messages about kept
packages.