Ruby updated to version 2.4 #1588
Conversation
There was a problem hiding this comment.
@rahul2240 thank you so much for the PR! 😍
First, I think c43e13c should be included in fb03bc5, as it is about adding ruby 2.4 to Travis. So please squash it. If you don't know how to do it please tell me and I will help you. 😉
Regarding Rubocop offenses, you shouldn't create an specific commit for that, but correct it in the commit where you introduce it. 🙂
You should also read our Commits section in our contributing guide. In this case I would find specially useful that you are a description in the commits explaining why everything is needed. so, for example, the nomethoderror temp fix. Why is that needed? Can you please elaborate there?
For example in #1583 you explainned why updating Rails is needed:
Rails update to 4.2.8 is necessary to get rid of Bignum and Fixnum warnings.
Ruby had two visible Integer classes: Fixnum and Bignum. Ruby 2.4 unifies them into Integer. All C extensions which touch the Fixnum or Bignum class need to be fixed.
I think this is a really good explanation and that this information would be really useful in the commit description. 👍 😉
Also, you should take a look why the test in Travis are failing. 🙂
This update is required to update yajl-ruby 1.2 to yajl-ruby 1.3 that support ruby 2.4
Rails update to 4.2.8 is necessary to get rid of Bignum and Fixnum warnings. Ruby had two visible Integer classes: Fixnum and Bignum. Ruby 2.4 unifies them into Integer. All C extensions which touch the Fixnum or Bignum class need to be fixed.
Updated this gem to fix nomethoderror old version of rspec use last_comment method which is deprecated in latest versions
Updated Webmock as previous version was not compatible with the new gems
|
@Ana06 Is everything ok now? I tried to do everything that you said. |
There was a problem hiding this comment.
@Ana06 Is everything ok now? I tried to do everything that you said.
Yes! Looks great! 😍 Thank you for adding the commit descriptions, I found them really useful! 😉
|
🎉 |
|
Thank you and congratulations on your first contribution @rahul2240 ! 😉 🎉 |
|
@shlok007 Thank you Sir! 😉 |
Ruby got updated in openSUSE#1588, But there was a repo missed, so Ruby 2.4 can be installed in our Vagrant machine. Mob-programmed by @mdeniz, @DavidKang and @Ana06.
Ruby got updated in openSUSE#1588, But there was a repo missed, so Ruby 2.4 can be installed in our Vagrant machine. Closes openSUSE#1601 Mob-programmed by @mdeniz, @DavidKang and @Ana06.
Ruby got updated in openSUSE#1588, But there was a repo missed, so Ruby 2.4 can be installed in our Vagrant machine. Closes openSUSE#1601 Mob-programmed by @mdeniz, @DavidKang and @Ana06.
Ruby got updated in #1588, But there was a repo missed, so Ruby 2.4 can be installed in our Vagrant machine. Closes #1601 Mob-programmed by @mdeniz, @DavidKang and @Ana06.
The aim is to update the ruby version to 2.4.
The Rails version is updated to 4.2.8 which support ruby version 2.4
Fixes issue #1563