Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The update to Ruby 2.4 broke the development environment (vagrant) #1601

Closed
AEtherC0r3 opened this issue Jul 18, 2017 · 7 comments
Closed

The update to Ruby 2.4 broke the development environment (vagrant) #1601

AEtherC0r3 opened this issue Jul 18, 2017 · 7 comments
Labels
bug 🐛 Something is wrong and needs to be fixed

Comments

@AEtherC0r3
Copy link
Contributor

It looks like the package ruby2.4-devel that was added in #1588 in bootstrap.sh doesn't exist in openSUSE 42.2 repositories

2017-07-18 10-43-58

@differentreality differentreality added bug 🐛 Something is wrong and needs to be fixed Grooming labels Jul 18, 2017
@differentreality
Copy link
Contributor

I get the same thing on a new vagrant box, and I can't zypper in ruby2.4-devel in vagrant either.

@rahul2240 any ideas? How did you get it working on your local instance?

@rahul2240
Copy link
Member

I am really sorry, i was continuously facing problems with setting up vagrant. so i didnt . I made these changes and osem started working on localhost. So i thought editing bootstrap.sh will work in vagrant. I apologize for my mistake.

@lagartoflojo
Copy link
Contributor

Do the new versions of gems from #1588 still work with the earlier Ruby version?
Maybe we ought to revert the changes to bootstrap.sh for now.

@AEtherC0r3
Copy link
Contributor Author

I'm getting the following warning in the rails console
Expected string default value for '--serializer'; got true (boolean)
irb: warn: can't alias context from irb_context.
Otherwise, the current master seems to work with the ruby2.3 package

@differentreality
Copy link
Contributor

I am having trouble with my student because of this change which is impossible to implement in vagrant.
Is there any solution for this? Otherwise we should revert the ruby version change in bootstrap.sh ASAP.

@lagartoflojo
Copy link
Contributor

Unfortunately, I never got Vagrant to work on my local machine, so I use Docker and I can't really test if Vagrant works.
I would revert the changes to bootstrap.sh (assuming everything else works OK).

@Ana06
Copy link
Member

Ana06 commented Jul 20, 2017

@lagartoflojo

Do the new versions of gems from #1588 still work with the earlier Ruby version?
Maybe we ought to revert the changes to bootstrap.sh for now.

I would revert the changes to bootstrap.sh (assuming everything else works OK).

Reverting to a previous Ruby version just because we have a missing repo in vagrant makes no sense at all. It is just a small fix. 🙈

@differentreality

I am having trouble with my student because of this change which is impossible to implement in vagrant.
Is there any solution for this? Otherwise we should revert the ruby version change in bootstrap.sh ASAP.

As said, it is just a small fix. I'll send a PR in a moment, so all of you can keep working. 😖

@rahul2240

I am really sorry, i was continuously facing problems with setting up vagrant. so i didn't . I made these changes and osem started working on localhost. So i thought editing bootstrap.sh will work in vagrant. I apologize for my mistake.

Don't worry. I also didn't try it in vagrant before merging it, my fault! 😖There is just a repo missed so Ruby 2.4 can be installed, I'll fix it. 😉

Ana06 added a commit to Ana06/osem that referenced this issue Jul 20, 2017
Ruby got updated in openSUSE#1588,
But there was a repo missed, so Ruby 2.4 can be installed in our Vagrant
machine.

Closes openSUSE#1601

Mob-programmed by @mdeniz, @DavidKang and @Ana06.
Ana06 added a commit to Ana06/osem that referenced this issue Jul 20, 2017
Ruby got updated in openSUSE#1588,
But there was a repo missed, so Ruby 2.4 can be installed in our Vagrant
machine.

Closes openSUSE#1601

Mob-programmed by @mdeniz, @DavidKang and @Ana06.
differentreality pushed a commit that referenced this issue Aug 11, 2017
Ruby got updated in #1588,
But there was a repo missed, so Ruby 2.4 can be installed in our Vagrant
machine.

Closes #1601

Mob-programmed by @mdeniz, @DavidKang and @Ana06.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug 🐛 Something is wrong and needs to be fixed
Projects
None yet
Development

No branches or pull requests

5 participants