Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Record new VCR cassette #838

Merged
merged 8 commits into from
Aug 4, 2020
Merged

Record new VCR cassette #838

merged 8 commits into from
Aug 4, 2020

Conversation

RobinSheps
Copy link
Contributor

I have recorded a new VCR cassette. It still needs tests added for Leap 15.2 as there are no tests for these as yet. I shall work on including them tomorrow. I have also updated the options.yaml to call build username and password from environment variables as per fix from Alexander Graul.

It is currently failing on the factory appdata test as it is returning 736 not the expected 739 (appdata_test.rb:L11). I am willing to hazard a guess that this is due to some packages being removed from factory but I am not sure where to find the data to double check.

I have added the pull request so others can use the new cassette for testing as well

@hellcp
Copy link
Member

hellcp commented Jul 8, 2020

It would probably be good to record the cassette in OBSTest with a binary that matches what is on build.opensuse.org, looking at the UI, there were quite a few rebuilds of the package in question. You will need to adjust the test for AppdataTest to match the current state of Factory ;)

@RobinSheps
Copy link
Contributor Author

RobinSheps commented Jul 8, 2020

I had planned on fixing the appdata test first, I spoke to Alexander Graul about the test and he said to change the test to the number in the response. Once I have that fixed and got a simple test for Leap 15.2 I was going to go through build.opensuse.org to get a package to test. If you have any particular suggestion as to a good candidate I am open to suggestions 😁

@agraul agraul self-requested a review July 16, 2020 21:05
Catching up to Ruby versions released on 2020-03-31
@agraul
Copy link
Member

agraul commented Aug 4, 2020

Given that we have an issue for the Ruby2.7 test failures (#815) and this cassette update unblocks testing other PRs I think we can merge it! Thanks @RobinSheps 🎉

@agraul agraul merged commit 6ee7da4 into openSUSE:master Aug 4, 2020
@agraul
Copy link
Member

agraul commented Aug 4, 2020

I forgot something, the backup of the cassette was not needed (since the older version is in git anyway). I'll remove it in a different PR.

@agraul agraul mentioned this pull request Oct 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants