Premature file end, incomplete collection

[geobrando]

Testing a source from the command line and the geojson ends before all of the records download or stream, leaving an invalid output file.

esri-dump http://maps.lex-co.com/arcgis/rest/services/AddressPts/MapServer/0 > output.geojson

Tested twice, and after adding a closing ]} I found incomplete collections and a different number of features. Click on the image to enlarge and see the record counts and the holes in the layer

[iandees]

The code in this repo isn't used by machine to fetch esri sources.
There's code within machine's cache.py to do that.

Not that this invalidates the bug...

[geobrando]

Good point. Source says skip so I assumed Machine's code also resulted in an error of some kind (there was no note). Going to remove the skip and see how Machine handles it.

[ingalls]

Closing as stale/in-actionable.