Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Saving / Caching Drawing Styles #262

Open
Dirk07 opened this issue Feb 1, 2023 · 3 comments
Open

Saving / Caching Drawing Styles #262

Dirk07 opened this issue Feb 1, 2023 · 3 comments

Comments

@Dirk07
Copy link
Collaborator

Dirk07 commented Feb 1, 2023

Hi @OpenAero ,

a friend of mine reported to me that any drawing styles, once changed from the default values, are apparently not saved / cached in the browser cache, unlike other settings that are remembered when openaero.net is called again through the browser, i.e. the setting for figure-numbers in entry circle.

I was able to reproduce and confirm this.

However, I'm not sure, whether this "auto-default-style" is intended or it has been foreseen to include also the drawing styles in the cache, but did accidentially not work.

On the other hand, if this is intended, the user must be given the option to save and load his settings (in particular the excessive settings for drawing styles) and preferences manually in a file, other than the sequence-files, of course.

Best regards,
Dirk

@OpenAero
Copy link
Owner

OpenAero commented Feb 2, 2023

The reversion of drawing styles to the default is intended. This prevents a user from having different styles by default, and in time possible forgetting they changed the style. When then creating and submitting sequences, these could come out very different from intended.

However, saving and then again loading changed settings sounds like a very useful addition. This should be implemented in the next update.

@Dirk07
Copy link
Collaborator Author

Dirk07 commented Feb 2, 2023

A competing (but not excluding) request to add the option of saving / loading such a setting file is to move the most frequently used drawing styles 'pos', 'neg', 'posfill' and 'negfill' to the style tab, where roll text size is to be selected. Apparently these settings are rather more frequently used by pilots, wearing glasses.
The sheer amount of remaining style settings in the expert tab is anyway overwhelming and perhaps not so often used, while at the same time it could be simpliefied, i.e. by introducing more general line-widths. A tabular form of these settings could fuether improve the appearance.

Another quick alternative to both proposals is to introduce only a 'I know what I do'-button to the expert tab, allowing to cache all the drawing styles.

OpenAero added a commit that referenced this issue Jun 11, 2023
* Moved Save dialog down index.html to assure it shows over other dialogs
* Added options to save and load drawing styles on Expert Settings (Issue #262)
@OpenAero
Copy link
Owner

Saving and loading of settings has been implemented. I don't like overcrowding the settings with many separate drawing options. But will keep this issue open regarding the other suggestions .

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants